a11y fixes #545
Merged
a11y fixes #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aria-hidden` is not a standard boolean attribute and must have an explicit true/false value.
✅ Deploy Preview for astro-www-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tony-sull
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
looks good to me! Yeah I'm not super happy with that open bug on Quill for their toolbar either, unfortunately at the time this was the most accessible MD->HTML editor I came across
@itsMapleLeaf might have a better solution for the new form, definitely something we can revisit 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit true value to
aria-hiddenwhere missingFix color contrast of links on theme pages
Also noticing that the Quill editor we’re using for the theme submission form is missing accessible labelling for its toolbar. There’s been an open PR to fix that on their end for nearly 6 months but seems maybe they’re not interested. Might be good to re-evaluate choice of text editor for the new site to see if there’s a more accessible alternative?