ComplexTableField Utility Links #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but I'll merge it to trunk. 2.4 isn't getting new features. |
…leField beyond just exporting (e.g. printing).
…ottom of table fields.
|
AJShort argued that this is a bugfix because the exclusion of the preexisting functionality is a bug. It seems pretty non-invasive. Ingo - do you think that it's okay for 2.4? |
|
Yeah, its not consistent with the parent implementation - looks good to me. |
mateusz
referenced
this pull request
in mateusz/sapphire
Apr 11, 2012
…s cbarberis, fixes pull request #1)
hdrlab
added a commit
to hdrlab/sapphire
that referenced
this pull request
May 9, 2012
…e main class doesn't have an allowed_actions array, but one or more of its extensions does. Background: I created a DataObjectDecorator for a form object that added an action. However, it refused to execute the action, giving an "action not allowed" error. Adding an allowed_actions array to the decorator was the only option, but caused RequestHandler::allowedActions() to fail with the following error: "Argument silverstripe#1 is not an array". This small patch eliminates the error. NOTES: - The reason why the new code is where it is, is so that the function still returns nothing (not even an empty array) if no actions are found - The master branch appears to also have the same defect, so it's worth checking that too, and fixing it if necessary
Closed
chillu
pushed a commit
that referenced
this pull request
May 8, 2013
Syncing back because I suck at Git
chillu
pushed a commit
that referenced
this pull request
Dec 19, 2013
chillu
added a commit
that referenced
this pull request
Sep 14, 2015
[ss-2015-016]: Fix XSS in install.php
flamerohr
referenced
this pull request
in silverstripe-terraformers/silverstripe-framework
May 25, 2016
…wyg-subsites to master * commit 'a784c04cfdeca2cffb975289d3f4788c0159edac': Correctly hide/show the subsite dropdown when changing link type
flamerohr
referenced
this pull request
in silverstripe-terraformers/silverstripe-framework
May 25, 2016
…US-97 to master * commit '94f56e6567d330dd8d777389c058d4a89fb5673e': WALRUS-97: Hide the status dots
4 tasks
ScopeyNZ
pushed a commit
that referenced
this pull request
Jul 13, 2020
Update 01_File_Management.md
maxime-rainville
pushed a commit
that referenced
this pull request
Dec 12, 2021
fix: don't use int width for mysql > 8.0.17 #9453
2 tasks
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableListField has support for utility links via the Utility method, with out of the box support for exporting via CSV and printing. ComplexTableField doesn't use this though, instead it just hard codes a CSV export link.
This fixes it to use the same mechanism as TableListField, so you can print ComplexTableFields as well as just exporting them. I also included a minor CSS fix so the links weren't chopped off.