MNT Fix unit test #11314
Merged
MNT Fix unit test #11314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jul 29, 2024
Comment on lines
-113
to
+115
| RememberLoginHash::config()->set('replace_token_during_session_renewal', $replaceToken); | ||
| Deprecation::withNoReplacement( | ||
| fn() => RememberLoginHash::config()->set('replace_token_during_session_renewal', $replaceToken) | ||
| ); |
There was a problem hiding this comment.
That config is deprecated, so we need to wrap this to avoid deprecation warnings when we go hunting for stuff we need to update for the final minor release.
|
phplinting failure is pre-existing and will be fixed by #11313 |
emteknetnz
approved these changes
Jul 29, 2024
emteknetnz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/recipe-core/actions/runs/10061752291/job/28027797761
Test was introduced in #11299
As per comments, if we don't fetch the hash from the DB, we still have the token which was generated for this hash, so the empty assertion fails.
Issue