Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Pass PSR6 caches to ChainAdapter #10506

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Sep 13, 2022

Should fix failing behat builds e.g. https://github.com/silverstripe/silverstripe-installer/actions/runs/3042293751/jobs/4900304892

Stack trace from error.log

[Tue Sep 13 03:29:16.688512 2022] [php:error] [pid 9394] [client ::1:36326] PHP Fatal error:  Uncaught Symfony\\Component\\Cache\\Exception\\InvalidArgumentException: The class "Symfony\\Component\\Cache\\Psr16Cache" does not implement the "Psr\\Cache\\CacheItemPoolInterface" interface. in /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/symfony/cache/Adapter/ChainAdapter.php:54

\nStack trace:\n

#0 /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/silverstripe/framework/src/Core/Cache/DefaultCacheFactory.php(164): Symfony\\Component\\Cache\\Adapter\\ChainAdapter->__construct()\n

#1 /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/silverstripe/framework/src/Core/Cache/DefaultCacheFactory.php(141): SilverStripe\\Core\\Cache\\DefaultCacheFactory->instantiateCache()\n

#2 /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/silverstripe/framework/src/Core/Cache/DefaultCacheFactory.php(87): SilverStripe\\Core\\Cache\\DefaultCacheFactory->createCache()\n

@GuySartorelli GuySartorelli merged commit 5da5555 into silverstripe:5 Sep 13, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/symfony-cache-fix branch September 13, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants