Expose functions to do preliminary slashing checks

[dknopik]

Thiiiis one is a bit spicy:

Currently, the slashing database only exposes functions to atomically check slashability of an attestation/block and then insert the corresponding data into the database. As this is done atomically, we can fearlessly sign the thing as other threads will definitely see the inserted data.

In Anchor, we first decide with the SSV committee which attestation/block we should sign, and then create a partial signature and broadcast it. Until now, we did the slashing check-and-insert right before creating the partial signature, and will continue to do so. However, we want to be able to check whether a thing is slashable in the first step, in order to not decide on a invalid value and then sign nothing, as the the slashing check fails.

Basically, we want to move from:

flowchart LR
    A@{ shape: sm-circ, label: "Small start" } --> Z[Wait for block]
    Z --> B[Decide block]
    B --> C{Is safe?}
    C -->|Yes| D[Create partial sig]
    C -->|No| E[Sign nothing]

Loading

to

flowchart LR
    A@{ shape: sm-circ, label: "Small start" } --> Z[Wait for block]
    Z --> C{"Is safe?<br>(check only)"}
    C -->|Yes| B[Decide block]
    C -->|No| Z
    B --> D{"Is safe?<br>(check and insert)"}
    D -->|Yes| H[Create partial sig]
    D -->|No| I[Sign nothing]

Loading

For this, we need to expose check only functions in the slashing database. This introduces a way for the user of the slashing database to shoot themselves in the foot.

[AgeManning]

I support these changes.

@michaelsproul suggested a good modification.

We probably should disallow these functions in lighthouse by doing something like this:
https://github.com/sigp/lighthouse/blob/stable/consensus/types/clippy.toml

and this:
https://github.com/sigp/lighthouse/blob/stable/consensus/types/src/lib.rs#L3-L10

[dknopik]

@michaelsproul good idea, done :)

[dknopik]

Not sure why this was here

[dknopik]

needed, as even disallowed methods may not call disallowed methods

[michaelsproul]

CI should pass now, we've bumped the HTTP test timeout on unstable

[michaelsproul]

LGTM, thanks!

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

• ☑️ local-testnet-success

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[michaelsproul]

@mergify requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

• ☑️ local-testnet-success

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.