-
Notifications
You must be signed in to change notification settings - Fork 929
Implement selections Beacon API endpoints to support DVT middleware
#7016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
selections API endpoints to support DVT middlewareselections Beacon API endpoints to support DVT middleware
|
With the commit 8b2f058 where VC sends partial signatures in parallel for all validators for a slot, I believe the aggregated attestations are successful (during testing) now, thank you @michaelsproul ! Lighthouse VC logs: for every slot now Charon logs: for every slot now too @KaloyanTanev could you give it a try and confirm that the beacon committee selection endpoint is working as intended? Thanks |
|
I am still confused about the |
|
Some required checks have failed. Could you please take a look @chong-he? 🙏 |
dknopik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the off-by-one is fixed, this is good to go from an Anchor point of view :)
Thank you @chong-he!
@michaelsproul can you please take a look when you have time?
| // For distributed mode | ||
| if duties_service | ||
| .sync_duties | ||
| .selection_proof_config | ||
| .parallel_sign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could think about re-combining these two cases in future, as the only substantial difference is the usage of FuturesUnordered in the non-distributed case. The non-distributed case is still parallel but it waits for all of the proofs to come in before writing them to the in-memory map. Whereas in the distributed case we add proofs as they become available. FuturesUnordered would likely be fine for both cases, and would save us a lot of duplication of logic.
I've opened an issue:
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…sigp#7016) * sigp#6610 - [x] Add `beacon_committee_selections` endpoint - [x] Test beacon committee aggregator and confirmed working - [x] Add `sync_committee_selections` endpoint - [x] Test sync committee aggregator and confirmed working
Issue Addressed
Proposed Changes
beacon_committee_selectionsendpointsync_committee_selectionsendpointAdditional Info
Thank you @michaelsproul and @macladson for the help and guidance