Skip to content

Expose functions to do preliminary slashing checks #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2025
Merged

Expose functions to do preliminary slashing checks #7783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79b64b9
Expose functions to do preliminary slashing checks
dknopik Jul 23, 2025
25d2406
Merge branch 'unstable' into spicy-prelim-slash-check
dknopik Sep 10, 2025
2a333c8
forbid prelim methods
dknopik Sep 10, 2025
338a470
Merge branch 'unstable' into spicy-prelim-slash-check
michaelsproul Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ perf.data*
*.tar.gz
/bin
genesis.ssz
/clippy.toml
Copy link
Member Author

@dknopik dknopik Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was here

/.cargo

# IntelliJ
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ lint:
-D clippy::fn_to_numeric_cast_any \
-D clippy::manual_let_else \
-D clippy::large_stack_frames \
-D clippy::disallowed_methods \
-D warnings \
-A clippy::derive_partial_eq_without_eq \
-A clippy::upper-case-acronyms \
Expand Down
7 changes: 7 additions & 0 deletions clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Disallow preliminary slashing checks,
disallowed-methods = [
{ path = "slashing_protection::slashing_database::SlashingDatabase::preliminary_check_block_proposal", reason = "not safe for slashing checks", replacement = "slashing_protection::slashing_database::SlashingDatabase::check_and_insert_block_proposal" },
{ path = "slashing_protection::slashing_database::SlashingDatabase::preliminary_check_block_signing_root", reason = "not safe for slashing checks", replacement = "slashing_protection::slashing_database::SlashingDatabase::check_and_insert_block_signing_root" },
{ path = "slashing_protection::slashing_database::SlashingDatabase::preliminary_check_attestation", reason = "not safe for slashing checks", replacement = "slashing_protection::slashing_database::SlashingDatabase::check_and_insert_attestation" },
{ path = "slashing_protection::slashing_database::SlashingDatabase::preliminary_check_attestation_signing_root", reason = "not safe for slashing checks", replacement = "slashing_protection::slashing_database::SlashingDatabase::check_and_insert_attestation_signing_root" },
]
2 changes: 2 additions & 0 deletions validator_client/slashing_protection/src/slashing_database.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ impl SlashingDatabase {
block_header: &BeaconBlockHeader,
domain: Hash256,
) -> Result<Safe, NotSafe> {
#[allow(clippy::disallowed_methods)]
Copy link
Member Author

@dknopik dknopik Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed, as even disallowed methods may not call disallowed methods

self.preliminary_check_block_signing_root(
validator_pubkey,
block_header.slot,
Expand Down Expand Up @@ -716,6 +717,7 @@ impl SlashingDatabase {
domain: Hash256,
) -> Result<Safe, NotSafe> {
let attestation_signing_root = attestation.signing_root(domain).into();
#[allow(clippy::disallowed_methods)]
self.preliminary_check_attestation_signing_root(
validator_pubkey,
attestation.source.epoch,
Expand Down
Loading