chore(homebrew): sort casks alphabetically - #723
Conversation
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the organization and readability of the Homebrew cask definitions within the Nix-Darwin configuration. By systematically arranging the cask entries in alphabetical order, the change makes the file easier to navigate and maintain for future updates, without affecting the system's functionality. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRSorted Homebrew casks alphabetically for better maintainability. What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to sort the Homebrew casks alphabetically, which is a good step for maintainability. However, I've found several instances where the new sorting order is incorrect. I've left specific comments with suggestions to fix the ordering. Please review these to ensure the list is correctly sorted.
| "beekeeper-studio" | ||
| "beeper" |
There was a problem hiding this comment.
The alphabetical sorting seems to be incorrect here. beeper should come before beekeeper-studio.
"beeper"
"beekeeper-studio"
| "claude-code" | ||
| "claude" | ||
| "openclaw" | ||
| "codex-app" | ||
| "codex" | ||
| "codexbar" |
There was a problem hiding this comment.
There are a few sorting issues in this block. The alphabetical order should be claude, claude-code, codex, codex-app, and then codexbar.
"claude"
"claude-code"
"codex"
"codex-app"
"codexbar"
| "font-jetbrains-mono-nerd-font" | ||
| "font-jetbrains-mono" |
There was a problem hiding this comment.
The sorting is incorrect here. font-jetbrains-mono should be listed before font-jetbrains-mono-nerd-font.
"font-jetbrains-mono"
"font-jetbrains-mono-nerd-font"
📝 WalkthroughSummary by CodeRabbit
WalkthroughModified the Homebrew casks list in nix-darwin configuration by reordering entries, adding new casks (claude-code, font-jetbrains-mono, codex-app), removing others (tailscale-app), and reorganizing font-related entries. Net change of 6 additions and 5 deletions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 0a26a23...a342af9
Analysis
- Sorting implementation is inconsistent and contains multiple ordering errors (e.g., 'claude-code' before 'claude', 'codex-app' before 'codex')
- Manual sorting approach appears error-prone and lacks systematic lexicographic ordering
- No automated verification (CI check or pre-commit hook) exists to maintain alphabetical ordering in future changes
- PR title claims complete alphabetical sorting but fails to deliver on this promise
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 3 comments | Edit Agent Settings • Read Docs
| "blender" | ||
| "block-goose" | ||
| "chatgpt" | ||
| "claude-code" |
There was a problem hiding this comment.
Incorrect alphabetical ordering: 'claude' should come before 'claude-code'. In alphabetical sorting, 'claude' (shorter string) comes before 'claude-code' since 'claude' is a prefix.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L69
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Incorrect alphabetical ordering: 'claude' should come before 'claude-code'. In alphabetical sorting, 'claude' (shorter string) comes before 'claude-code' since 'claude' is a prefix.
| "claude-code" | ||
| "claude" | ||
| "openclaw" | ||
| "codex-app" |
There was a problem hiding this comment.
Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L71
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.
| "font-hack-nerd-font" | ||
| "font-jetbrains-mono" | ||
| "font-jetbrains-mono-nerd-font" | ||
| "font-jetbrains-mono" |
There was a problem hiding this comment.
Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L86
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.
There was a problem hiding this comment.
Pull request overview
This PR aims to sort homebrew casks alphabetically in the nix-darwin configuration for better maintainability. However, the sorting is incomplete and contains several alphabetical ordering errors.
Changes:
- Reordered cask entries in the homebrew configuration file
- Moved several casks to different positions to achieve alphabetical ordering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "claude-code" | ||
| "claude" |
There was a problem hiding this comment.
The casks are not sorted correctly alphabetically. "claude" should come before "claude-code" in alphabetical order. The hyphen should not affect the basic alphabetical ordering of the base name.
| "claude-code" | |
| "claude" | |
| "claude" | |
| "claude-code" |
| "codex-app" | ||
| "codex" |
There was a problem hiding this comment.
The casks are not sorted correctly alphabetically. "codex" should come before "codex-app" in alphabetical order. The hyphen should not affect the basic alphabetical ordering of the base name.
| "codex-app" | |
| "codex" | |
| "codex" | |
| "codex-app" |
| "font-jetbrains-mono-nerd-font" | ||
| "font-jetbrains-mono" |
There was a problem hiding this comment.
The casks are not sorted correctly alphabetically. "font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" in alphabetical order. When one string is a prefix of another, the shorter string should come first.
| "font-jetbrains-mono-nerd-font" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono-nerd-font" |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@nix-darwin/config/homebrew.nix`:
- Around line 69-72: The list of Homebrew casks in the attribute set is not
alphabetically ordered: swap the entries so "claude" appears before
"claude-code" and "codex" appears before "codex-app" to maintain correct
alphabetical ordering in the cask list (the relevant entries shown are
"claude-code", "claude", "codex-app", "codex").
- Around line 85-86: The font list is not alphabetically sorted: place
"font-jetbrains-mono" before "font-jetbrains-mono-nerd-font" so the entries in
the attribute set are in correct alphabetical order; locate the font entries
(the two strings "font-jetbrains-mono" and "font-jetbrains-mono-nerd-font") in
the list and swap their positions to ensure "font-jetbrains-mono" comes first.
| "claude-code" | ||
| "claude" | ||
| "openclaw" | ||
| "codex-app" | ||
| "codex" |
There was a problem hiding this comment.
Casks are not correctly sorted alphabetically.
The PR title indicates alphabetical sorting, but these entries are in incorrect order. Alphabetically, shorter prefix strings should precede longer ones:
"claude"should come before"claude-code""codex"should come before"codex-app"
🔧 Proposed fix for correct alphabetical order
"chatgpt"
- "claude-code"
"claude"
- "codex-app"
+ "claude-code"
"codex"
+ "codex-app"
"codexbar"Based on learnings: "Sort attribute sets alphabetically in Nix files"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "claude-code" | |
| "claude" | |
| "openclaw" | |
| "codex-app" | |
| "codex" | |
| "claude" | |
| "claude-code" | |
| "codex" | |
| "codex-app" |
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 69 - 72, The list of Homebrew
casks in the attribute set is not alphabetically ordered: swap the entries so
"claude" appears before "claude-code" and "codex" appears before "codex-app" to
maintain correct alphabetical ordering in the cask list (the relevant entries
shown are "claude-code", "claude", "codex-app", "codex").
| "font-jetbrains-mono-nerd-font" | ||
| "font-jetbrains-mono" |
There was a problem hiding this comment.
Font entries are not correctly sorted alphabetically.
"font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" since the former is a prefix of the latter.
🔧 Proposed fix for correct alphabetical order
"font-hack-nerd-font"
- "font-jetbrains-mono-nerd-font"
"font-jetbrains-mono"
+ "font-jetbrains-mono-nerd-font"
"ghostty"As per coding guidelines: "Sort attribute sets alphabetically in Nix files"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "font-jetbrains-mono-nerd-font" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono-nerd-font" |
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 85 - 86, The font list is not
alphabetically sorted: place "font-jetbrains-mono" before
"font-jetbrains-mono-nerd-font" so the entries in the attribute set are in
correct alphabetical order; locate the font entries (the two strings
"font-jetbrains-mono" and "font-jetbrains-mono-nerd-font") in the list and swap
their positions to ensure "font-jetbrains-mono" comes first.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="nix-darwin/config/homebrew.nix">
<violation number="1" location="nix-darwin/config/homebrew.nix:71">
P2: Alphabetical sorting violation: "codex" should come before "codex-app".
Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "codex-app" | ||
| "codex" |
There was a problem hiding this comment.
P2: Alphabetical sorting violation: "codex" should come before "codex-app".
Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At nix-darwin/config/homebrew.nix, line 71:
<comment>Alphabetical sorting violation: "codex" should come before "codex-app".
Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").</comment>
<file context>
@@ -61,16 +61,16 @@
+ "claude-code"
"claude"
- "openclaw"
+ "codex-app"
"codex"
"codexbar"
</file context>
| "codex-app" | |
| "codex" | |
| "codex"\n "codex-app" |
Changes
Technical Details
Testing
Generated with [Claude Code] by [glm-4.7]
Summary by cubic
Sorted Homebrew casks alphabetically in nix-darwin/config/homebrew.nix to improve readability and maintenance. No functional changes; configuration builds successfully.
Written for commit a342af9. Summary will update on new commits.