Repository navigation
chore(homebrew): sort casks alphabetically #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -61,16 +61,16 @@ | |||||||||||||||||||||||||||||||||
| "antigravity" | ||||||||||||||||||||||||||||||||||
| "atuin-desktop" | ||||||||||||||||||||||||||||||||||
| "balenaetcher" | ||||||||||||||||||||||||||||||||||
| "beeper" | ||||||||||||||||||||||||||||||||||
| "beekeeper-studio" | ||||||||||||||||||||||||||||||||||
| "beeper" | ||||||||||||||||||||||||||||||||||
| "blender" | ||||||||||||||||||||||||||||||||||
| "block-goose" | ||||||||||||||||||||||||||||||||||
| "chatgpt" | ||||||||||||||||||||||||||||||||||
| "claude-code" | ||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incorrect alphabetical ordering: 'claude' should come before 'claude-code'. In alphabetical sorting, 'claude' (shorter string) comes before 'claude-code' since 'claude' is a prefix. Prompt for Agent |
||||||||||||||||||||||||||||||||||
| "claude" | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+69
to
70
|
||||||||||||||||||||||||||||||||||
| "claude-code" | |
| "claude" | |
| "claude" | |
| "claude-code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L71
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The casks are not sorted correctly alphabetically. "codex" should come before "codex-app" in alphabetical order. The hyphen should not affect the basic alphabetical ordering of the base name.
| "codex-app" | |
| "codex" | |
| "codex" | |
| "codex-app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casks are not correctly sorted alphabetically.
The PR title indicates alphabetical sorting, but these entries are in incorrect order. Alphabetically, shorter prefix strings should precede longer ones:
"claude"should come before"claude-code""codex"should come before"codex-app"
🔧 Proposed fix for correct alphabetical order
"chatgpt"
- "claude-code"
"claude"
- "codex-app"
+ "claude-code"
"codex"
+ "codex-app"
"codexbar"Based on learnings: "Sort attribute sets alphabetically in Nix files"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "claude-code" | |
| "claude" | |
| "openclaw" | |
| "codex-app" | |
| "codex" | |
| "claude" | |
| "claude-code" | |
| "codex" | |
| "codex-app" |
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 69 - 72, The list of Homebrew
casks in the attribute set is not alphabetically ordered: swap the entries so
"claude" appears before "claude-code" and "codex" appears before "codex-app" to
maintain correct alphabetical ordering in the cask list (the relevant entries
shown are "claude-code", "claude", "codex-app", "codex").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Alphabetical sorting violation: "codex" should come before "codex-app".
Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At nix-darwin/config/homebrew.nix, line 71:
<comment>Alphabetical sorting violation: "codex" should come before "codex-app".
Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").</comment>
<file context>
@@ -61,16 +61,16 @@
+ "claude-code"
"claude"
- "openclaw"
+ "codex-app"
"codex"
"codexbar"
</file context>
| "codex-app" | |
| "codex" | |
| "codex"\n "codex-app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L86
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The casks are not sorted correctly alphabetically. "font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" in alphabetical order. When one string is a prefix of another, the shorter string should come first.
| "font-jetbrains-mono-nerd-font" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono-nerd-font" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font entries are not correctly sorted alphabetically.
"font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" since the former is a prefix of the latter.
🔧 Proposed fix for correct alphabetical order
"font-hack-nerd-font"
- "font-jetbrains-mono-nerd-font"
"font-jetbrains-mono"
+ "font-jetbrains-mono-nerd-font"
"ghostty"As per coding guidelines: "Sort attribute sets alphabetically in Nix files"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "font-jetbrains-mono-nerd-font" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono" | |
| "font-jetbrains-mono-nerd-font" |
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 85 - 86, The font list is not
alphabetically sorted: place "font-jetbrains-mono" before
"font-jetbrains-mono-nerd-font" so the entries in the attribute set are in
correct alphabetical order; locate the font entries (the two strings
"font-jetbrains-mono" and "font-jetbrains-mono-nerd-font") in the list and swap
their positions to ensure "font-jetbrains-mono" comes first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alphabetical sorting seems to be incorrect here.
beepershould come beforebeekeeper-studio.