Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions nix-darwin/config/homebrew.nix
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
"antigravity"
"atuin-desktop"
"balenaetcher"
"beeper"
"beekeeper-studio"
"beeper"
Comment on lines 64 to +65

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The alphabetical sorting seems to be incorrect here. beeper should come before beekeeper-studio.

      "beeper"
      "beekeeper-studio"

"blender"
"block-goose"
"chatgpt"
"claude-code"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Incorrect alphabetical ordering: 'claude' should come before 'claude-code'. In alphabetical sorting, 'claude' (shorter string) comes before 'claude-code' since 'claude' is a prefix.

Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L69
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Incorrect alphabetical ordering: 'claude' should come before 'claude-code'. In alphabetical sorting, 'claude' (shorter string) comes before 'claude-code' since 'claude' is a prefix.

"claude"
Comment on lines +69 to 70

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The casks are not sorted correctly alphabetically. "claude" should come before "claude-code" in alphabetical order. The hyphen should not affect the basic alphabetical ordering of the base name.

Suggested change
"claude-code"
"claude"
"claude"
"claude-code"

Copilot uses AI. Check for mistakes.
"openclaw"
"codex-app"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.

Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L71
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Incorrect alphabetical ordering: 'codex' should come before 'codex-app'. Similar to the claude/claude-code issue, the base name should come before its hyphenated variants.

"codex"
Comment on lines +71 to 72

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The casks are not sorted correctly alphabetically. "codex" should come before "codex-app" in alphabetical order. The hyphen should not affect the basic alphabetical ordering of the base name.

Suggested change
"codex-app"
"codex"
"codex"
"codex-app"

Copilot uses AI. Check for mistakes.
Comment on lines +69 to 72

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Casks are not correctly sorted alphabetically.

The PR title indicates alphabetical sorting, but these entries are in incorrect order. Alphabetically, shorter prefix strings should precede longer ones:

  • "claude" should come before "claude-code"
  • "codex" should come before "codex-app"
🔧 Proposed fix for correct alphabetical order
       "chatgpt"
-      "claude-code"
       "claude"
-      "codex-app"
+      "claude-code"
       "codex"
+      "codex-app"
       "codexbar"

Based on learnings: "Sort attribute sets alphabetically in Nix files"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"claude-code"
"claude"
"openclaw"
"codex-app"
"codex"
"claude"
"claude-code"
"codex"
"codex-app"
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 69 - 72, The list of Homebrew
casks in the attribute set is not alphabetically ordered: swap the entries so
"claude" appears before "claude-code" and "codex" appears before "codex-app" to
maintain correct alphabetical ordering in the cask list (the relevant entries
shown are "claude-code", "claude", "codex-app", "codex").

Comment on lines +71 to 72

@cubic-dev-ai cubic-dev-ai Bot Feb 4, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Alphabetical sorting violation: "codex" should come before "codex-app".

Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At nix-darwin/config/homebrew.nix, line 71:

<comment>Alphabetical sorting violation: "codex" should come before "codex-app".

Additionally, this adds a new cask "codex-app", which is a functional change not mentioned in the PR description ("purely cosmetic").</comment>

<file context>
@@ -61,16 +61,16 @@
+      "claude-code"
       "claude"
-      "openclaw"
+      "codex-app"
       "codex"
       "codexbar"
</file context>
Suggested change
"codex-app"
"codex"
"codex"\n "codex-app"
Fix with Cubic

"codexbar"
Comment on lines +69 to 73

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There are a few sorting issues in this block. The alphabetical order should be claude, claude-code, codex, codex-app, and then codexbar.

      "claude"
      "claude-code"
      "codex"
      "codex-app"
      "codexbar"

"claude-code"
"conductor"
"copilot-money"
"cursor"
Expand All @@ -82,8 +82,8 @@
"firefox"
"flameshot"
"font-hack-nerd-font"
"font-jetbrains-mono"
"font-jetbrains-mono-nerd-font"
"font-jetbrains-mono"
Comment on lines 85 to +86

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The sorting is incorrect here. font-jetbrains-mono should be listed before font-jetbrains-mono-nerd-font.

      "font-jetbrains-mono"
      "font-jetbrains-mono-nerd-font"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.

Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#723
File: nix-darwin/config/homebrew.nix#L86
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Incorrect alphabetical ordering: 'font-jetbrains-mono' should come before 'font-jetbrains-mono-nerd-font'. The shorter string without '-nerd-font' suffix should appear first.

Comment on lines 85 to +86

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The casks are not sorted correctly alphabetically. "font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" in alphabetical order. When one string is a prefix of another, the shorter string should come first.

Suggested change
"font-jetbrains-mono-nerd-font"
"font-jetbrains-mono"
"font-jetbrains-mono"
"font-jetbrains-mono-nerd-font"

Copilot uses AI. Check for mistakes.
Comment on lines 85 to +86

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Font entries are not correctly sorted alphabetically.

"font-jetbrains-mono" should come before "font-jetbrains-mono-nerd-font" since the former is a prefix of the latter.

🔧 Proposed fix for correct alphabetical order
       "font-hack-nerd-font"
-      "font-jetbrains-mono-nerd-font"
       "font-jetbrains-mono"
+      "font-jetbrains-mono-nerd-font"
       "ghostty"

As per coding guidelines: "Sort attribute sets alphabetically in Nix files"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"font-jetbrains-mono-nerd-font"
"font-jetbrains-mono"
"font-jetbrains-mono"
"font-jetbrains-mono-nerd-font"
🤖 Prompt for AI Agents
In `@nix-darwin/config/homebrew.nix` around lines 85 - 86, The font list is not
alphabetically sorted: place "font-jetbrains-mono" before
"font-jetbrains-mono-nerd-font" so the entries in the attribute set are in
correct alphabetical order; locate the font entries (the two strings
"font-jetbrains-mono" and "font-jetbrains-mono-nerd-font") in the list and swap
their positions to ensure "font-jetbrains-mono" comes first.

"ghostty"
"github"
"google-chrome"
Expand All @@ -94,13 +94,15 @@
"lm-studio"
"notion"
"ollama-app"
"openclaw"
"opencode-desktop"
"raycast"
"repobar"
"rescuetime"
"screen-studio"
"sf-symbols"
"slack"
"tailscale-app"
"trae"
"visual-studio-code"
"visual-studio-code@insiders"
Expand All @@ -110,7 +112,6 @@
"windsurf"
"zed"
"zoom"
"tailscale-app"
];
masApps = {
"Apollo" = 6448019325;
Expand Down
Loading