chore(homebrew): move droid from brews to casks - #302
Conversation
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Homebrew configuration by correcting the categorization of the 'droid' package. It ensures that 'droid' is installed as a cask rather than a brew, aligning with its nature as an application rather than a command-line tool, and maintains the alphabetical integrity of the package lists. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change reclassifies the "droid" package from Homebrew brews to casks in the nix-darwin configuration. The package is removed from one list and added to another, with no modifications to configuration logic or structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
Refactors homebrew package management by moving the "droid" package from the brews list to the casks list, reflecting its proper categorization as a GUI application rather than a command-line tool.
- Move "droid" from brews to casks list
- Maintain alphabetical ordering in the casks list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the droid package from the brews list to the casks list in the Homebrew configuration. This is the appropriate change as droid is a GUI application. The alphabetical order of the casks list has been correctly maintained after the addition. The changes are straightforward and look good.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
nix-darwin/config/homebrew.nix(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.nix
📄 CodeRabbit inference engine (CLAUDE.md)
Format all Nix files with nixfmt
**/*.nix: Nix: Use 2 spaces for indentation
Nix: Keep line length under 100 characters
Nix: Sort attribute sets alphabetically
Nix: Use consistent spacing around operators
Nix: Format lists and sets consistentlyFollow the Nix expression language style guide
Files:
nix-darwin/config/homebrew.nix
nix-darwin/**
📄 CodeRabbit inference engine (CLAUDE.md)
Use Homebrew only for macOS-specific applications within nix-darwin configs
Keep Darwin-specific configurations under nix-darwin/
Files:
nix-darwin/config/homebrew.nix
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: shunkakinoki/dotfiles#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-28T16:25:07.125Z
Learning: Applies to nix-darwin/** : Use Homebrew only for macOS-specific applications within nix-darwin configs
📚 Learning: 2025-09-28T16:25:07.125Z
Learnt from: CR
PR: shunkakinoki/dotfiles#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-28T16:25:07.125Z
Learning: Applies to nix-darwin/** : Use Homebrew only for macOS-specific applications within nix-darwin configs
Applied to files:
nix-darwin/config/homebrew.nix
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: nix-linux
- GitHub Check: nix-darwin
- GitHub Check: nix-nixos
- GitHub Check: e2e-run (Ubuntu, ubuntu-latest)
- GitHub Check: e2e-run (MacOS, macos-latest)
- GitHub Check: e2e-run (NixOS, ubuntu-latest)
- GitHub Check: docker-build-push (linux/amd64, -amd64, amd64)
| "cursor" | ||
| "discord" | ||
| "docker-desktop" | ||
| "droid" |
There was a problem hiding this comment.
🧩 Analysis chain
Verify "droid" is distributed as a Homebrew cask.
The reclassification from brew to cask implies "droid" is a GUI application rather than a CLI tool. Please confirm that "droid" is actually available as a Homebrew cask and is macOS-specific (per the coding guidelines for nix-darwin configs).
Run the following script to verify "droid" exists as a Homebrew cask:
Additionally, you may want to search the web to confirm the correct Homebrew distribution method for "droid":
Based on learnings.
🏁 Script executed:
#!/bin/bash
# Description: Verify "droid" is available as a Homebrew cask and check its description
# Check if "droid" exists as a cask
brew info --cask droid 2>/dev/null || echo "ERROR: 'droid' cask not found"
# Also check if it might still exist as a formula (brew)
echo "---"
echo "Checking if 'droid' exists as a formula:"
brew info droid 2>/dev/null || echo "INFO: 'droid' formula not found (expected)"Length of output: 117
🌐 Web query:
Homebrew droid cask
💡 Result:
Do you mean:
- installing the F‑Droid client or fdroidserver via Homebrew,
- a Homebrew Cask named “droid” (a font or app),
- or something else (e.g., Android SDK / Droid tools)?
Tell me which and I’ll give exact brew commands and links.
Remove or correct "droid"—it does not exist as a Homebrew cask.
Verification confirms that "droid" is not available as a Homebrew cask or formula. Adding it to the casks list will cause nix-darwin activation to fail. Either remove this line or clarify the intended package (e.g., F-Droid, fdroidserver, or Android SDK tools).
🤖 Prompt for AI Agents
In nix-darwin/config/homebrew.nix around line 48, the cask entry "droid" is
invalid and will break activation; remove that line or replace it with the
correct Homebrew cask/formula name (e.g., the intended package such as
android-platform-tools, android-sdk, fdroidserver, or another exact nixpkgs
package), then verify the chosen name exists via brew search or nixpkgs and
re-run nix-darwin activation to confirm the error is resolved.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary
Summary by cubic
Moved droid from Homebrew brews to casks in nix-darwin to install the correct package type and maintain alphabetical order.