fix(skills): propagate re-lock failure, document prerequisites

[shunkakinoki]

Follow-ups from #176 review:

• skills-install now sets failed=1 when the post-install skills-lock regeneration fails, instead of exiting 0 with a stale lock
• README notes that make skills-lock requires the global CLI lock (created by the first global install)
• README + rules document the one-time bootstrap for install-all repos (bunx skills add owner/repo --global --yes --skill '*')

🤖 Generated with Claude Code

---

Summary by cubic

Propagates skills-lock regeneration failures from skills-install to prevent stale locks. Adds docs for the required global lock and a one-time bootstrap for install-all repos.

• Bug Fixes

  • make skills-install now exits non-zero if the post-install make skills-lock step fails (sets failed=1), avoiding stale locks.

• Migration

  • make skills-lock requires the global CLI lock at ~/.agents/.skill-lock.json (created by the first global install).
  • For install-all repos (no selection), run once: bunx skills add owner/repo --global --yes --skill '*' before locking.

^{Written for commit f7d26e8. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

@shunkakinoki, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 333217e9-aa37-4424-8107-89b247fc5c19

📥 Commits

Reviewing files that changed from the base of the PR and between cee1b1c and f7d26e8.

📒 Files selected for processing (3)

• Makefile
• README.md
• rules/skills-management.md

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="rules/skills-management.md">

<violation number="1" location="rules/skills-management.md:29">
P2: Following this snippet literally (bootstrap after `make skills-install`, then commit) commits a stale skills-lock.json, because the lock only records skills already installed on disk and the bootstrap installs them after the lock was regenerated. Suggest noting the bootstrap should run before the install/lock step, or that `make skills-lock` be re-run after it, to match the README's 'then make skills-lock'.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Following this snippet literally (bootstrap after make skills-install, then commit) commits a stale skills-lock.json, because the lock only records skills already installed on disk and the bootstrap installs them after the lock was regenerated. Suggest noting the bootstrap should run before the install/lock step, or that make skills-lock be re-run after it, to match the README's 'then make skills-lock'.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At rules/skills-management.md, line 29:

<comment>Following this snippet literally (bootstrap after `make skills-install`, then commit) commits a stale skills-lock.json, because the lock only records skills already installed on disk and the bootstrap installs them after the lock was regenerated. Suggest noting the bootstrap should run before the install/lock step, or that `make skills-lock` be re-run after it, to match the README's 'then make skills-lock'.</comment>

<file context>
@@ -26,6 +26,9 @@ bunx skills add owner/repo --global --list
 # 3. Install (regenerates skills-lock.json from SKILLS.txt automatically)
 cd dotagents && make skills-install
 
+# Install-all repos (no selection) need a one-time bootstrap to enter the lock:
+# bunx skills add owner/repo --global --yes --skill '*'
+
</file context>

Suggested change

	# Install-all repos (no selection) need a one-time bootstrap to enter the lock:
	# bunx skills add owner/repo --global --yes --skill '*'
	# Install-all repos (no selection) need a one-time bootstrap — run it before the
	# regenerate step, or re-run `make skills-lock` after it, so the skills enter the lock:
	# bunx skills add owner/repo --global --yes --skill '*'