Skip to content

fix(skills): propagate re-lock failure, document prerequisites #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Aug 2, 2026
Merged

fix(skills): propagate re-lock failure, document prerequisites #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ skills-install: ## Install external skills declared in SKILLS.txt (skips already
done; \
rm -f "$$tmp_missing"; \
if [ -f "$(SKILLS_GLOBAL_LOCK)" ]; then \
$(MAKE) skills-lock; \
$(MAKE) skills-lock || failed=1; \
fi; \
exit $$failed

Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ make skills-install
make skills-update

# Regenerate skills-lock.json from SKILLS.txt without installing
# (requires ~/.agents/.skill-lock.json, created by the first global install)
make skills-lock

# Force a reinstall of everything in the lock
make skills-refresh
```

To add skills: edit `SKILLS.txt`, run `make skills-install`, and commit both files. To remove: delete from `SKILLS.txt`, run `bunx skills remove <name> --global --yes`, then `make skills-lock`.
To add skills: edit `SKILLS.txt`, run `make skills-install`, and commit both files. Install-all repos (no selection) need a one-time bootstrap before they appear in the lock: `bunx skills add owner/repo --global --yes --skill '*'` (the `make skills-lock` warning prints the exact command), then `make skills-lock`. To remove: delete from `SKILLS.txt`, run `bunx skills remove <name> --global --yes`, then `make skills-lock`.

Installs track each source's default branch: the skills CLI does not record commit SHAs in its lock yet, so entries are not pinned to a commit.
3 changes: 3 additions & 0 deletions rules/skills-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ bunx skills add owner/repo --global --list
# 3. Install (regenerates skills-lock.json from SKILLS.txt automatically)
cd dotagents && make skills-install

# Install-all repos (no selection) need a one-time bootstrap to enter the lock:
# bunx skills add owner/repo --global --yes --skill '*'
Comment on lines +29 to +30

@cubic-dev-ai cubic-dev-ai Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Following this snippet literally (bootstrap after make skills-install, then commit) commits a stale skills-lock.json, because the lock only records skills already installed on disk and the bootstrap installs them after the lock was regenerated. Suggest noting the bootstrap should run before the install/lock step, or that make skills-lock be re-run after it, to match the README's 'then make skills-lock'.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At rules/skills-management.md, line 29:

<comment>Following this snippet literally (bootstrap after `make skills-install`, then commit) commits a stale skills-lock.json, because the lock only records skills already installed on disk and the bootstrap installs them after the lock was regenerated. Suggest noting the bootstrap should run before the install/lock step, or that `make skills-lock` be re-run after it, to match the README's 'then make skills-lock'.</comment>

<file context>
@@ -26,6 +26,9 @@ bunx skills add owner/repo --global --list
 # 3. Install (regenerates skills-lock.json from SKILLS.txt automatically)
 cd dotagents && make skills-install
 
+# Install-all repos (no selection) need a one-time bootstrap to enter the lock:
+# bunx skills add owner/repo --global --yes --skill '*'
+
</file context>
Suggested change
# Install-all repos (no selection) need a one-time bootstrap to enter the lock:
# bunx skills add owner/repo --global --yes --skill '*'
# Install-all repos (no selection) need a one-time bootstrap — run it before the
# regenerate step, or re-run `make skills-lock` after it, so the skills enter the lock:
# bunx skills add owner/repo --global --yes --skill '*'


# 4. Commit SKILLS.txt and skills-lock.json together
```

Expand Down