Skip to content

feat(skills): add skills-update, drive install from SKILLS.txt - #176

Merged
shunkakinoki merged 1 commit into
mainfrom
feat/skills-update-target
Aug 2, 2026
Merged

feat(skills): add skills-update, drive install from SKILLS.txt#176
shunkakinoki merged 1 commit into
mainfrom
feat/skills-update-target

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 2, 2026

Copy link
Copy Markdown
Owner

What

  • make skills-install now regenerates skills-lock.json from SKILLS.txt before installing (when the global CLI lock exists) and re-locks after installing, so adding a skill is: edit SKILLS.txt -> make skills-install -> commit both files. SKILLS.txt is the single source of truth; the lock is a derived artifact.
  • New make skills-update: runs bun x skills update --global --yes then refreshes the lock.
  • Docs updated (README, rules/skills-management.md).

Fresh machines are unaffected: with no global CLI lock present, skills-install skips regeneration and restores straight from the committed lock (and re-locks at the end once the CLI has created the global lock).

Testing

Removed a skill via the CLI, edited nothing, ran a single make skills-install: the pre-install lock regen flagged it (555 skills, 1 not yet installed), reinstalled it, and the post-install re-lock resolved its skillFolderHash. Exit 0.

🤖 Generated with Claude Code


Summary by cubic

Made SKILLS.txt the source of truth for external skills installs and added make skills-update to refresh installed skills and the lock. This streamlines add/update workflows while keeping fresh machine restores unchanged.

  • New Features

    • skills-install installs from SKILLS.txt and auto-regenerates skills-lock.json before/after when SKILLS_GLOBAL_LOCK exists; skips regen on fresh machines.
    • skills-update runs bun x skills update --global --yes and then refreshes the lock.
  • Migration

    • Add: edit SKILLS.txt, run make skills-install, commit SKILLS.txt and skills-lock.json.
    • Remove: delete from SKILLS.txt, run bunx skills remove <name> --global --yes, then make skills-lock.
    • Restore (fresh machines/CI): run make skills-install to install from the committed lock.

Written for commit 924dd6b. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added a command to update globally installed skills and regenerate the lockfile.
    • Skill installation now uses declared skills and keeps the lockfile synchronized automatically.
  • Documentation

    • Documented commands for installing, updating, locking, and reinstalling skills.
    • Updated skill addition and management instructions to include lockfile changes.

Walkthrough

The Makefile now installs skills from SKILLS.txt, synchronizes skills-lock.json, and adds a global update target. The README and skills-management rules document the revised installation, update, lockfile, and contribution workflows.

Changes

Skills management workflow

Layer / File(s) Summary
Install and update targets
Makefile
skills-install refreshes the lockfile before and after installation when a global lock exists. skills-update updates globally installed skills and regenerates the local lockfile.
Command and contribution instructions
README.md, rules/skills-management.md
Documentation describes installation, updates, lockfile regeneration, forced reinstallation, and committing SKILLS.txt with skills-lock.json.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit finds skills in a list,
Then locks each one with a twist.
Install, update, lock,
Commands hop round the clock.
Both files now join the commit.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the new skills-update target and the change to use SKILLS.txt as the install source.
Description check ✅ Passed The description directly explains the Makefile changes, workflows, documentation updates, and testing results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/skills-update-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Around line 126-129: Update the post-install lock handling in the Makefile
recipe so a failing nested `$(MAKE) skills-lock` explicitly sets `failed=1`
before the final `exit $$failed`. Preserve the existing conditional execution
based on `SKILLS_GLOBAL_LOCK` and ensure the nested make failure propagates even
when installation otherwise succeeds.

In `@README.md`:
- Around line 24-25: Update the README section containing the “make skills-lock”
command to state that SKILLS_GLOBAL_LOCK must be set before running it, while
preserving the existing instruction that the command regenerates
skills-lock.json without installing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e706a7a-28f8-4dc4-b21a-80bd03a4f6d3

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac703d and 924dd6b.

📒 Files selected for processing (3)
  • Makefile
  • README.md
  • rules/skills-management.md

Comment thread Makefile
Comment thread README.md

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread README.md
Comment thread Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant