feat(skills): add skills-update, drive install from SKILLS.txt - #176
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Makefile now installs skills from ChangesSkills management workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 126-129: Update the post-install lock handling in the Makefile
recipe so a failing nested `$(MAKE) skills-lock` explicitly sets `failed=1`
before the final `exit $$failed`. Preserve the existing conditional execution
based on `SKILLS_GLOBAL_LOCK` and ensure the nested make failure propagates even
when installation otherwise succeeds.
In `@README.md`:
- Around line 24-25: Update the README section containing the “make skills-lock”
command to state that SKILLS_GLOBAL_LOCK must be set before running it, while
preserving the existing instruction that the command regenerates
skills-lock.json without installing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0e706a7a-28f8-4dc4-b21a-80bd03a4f6d3
📒 Files selected for processing (3)
MakefileREADME.mdrules/skills-management.md
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
What
make skills-installnow regeneratesskills-lock.jsonfromSKILLS.txtbefore installing (when the global CLI lock exists) and re-locks after installing, so adding a skill is: editSKILLS.txt->make skills-install-> commit both files. SKILLS.txt is the single source of truth; the lock is a derived artifact.make skills-update: runsbun x skills update --global --yesthen refreshes the lock.Fresh machines are unaffected: with no global CLI lock present,
skills-installskips regeneration and restores straight from the committed lock (and re-locks at the end once the CLI has created the global lock).Testing
Removed a skill via the CLI, edited nothing, ran a single
make skills-install: the pre-install lock regen flagged it (555 skills, 1 not yet installed), reinstalled it, and the post-install re-lock resolved itsskillFolderHash. Exit 0.🤖 Generated with Claude Code
Summary by cubic
Made
SKILLS.txtthe source of truth for external skills installs and addedmake skills-updateto refresh installed skills and the lock. This streamlines add/update workflows while keeping fresh machine restores unchanged.New Features
skills-installinstalls fromSKILLS.txtand auto-regeneratesskills-lock.jsonbefore/after whenSKILLS_GLOBAL_LOCKexists; skips regen on fresh machines.skills-updaterunsbun x skills update --global --yesand then refreshes the lock.Migration
SKILLS.txt, runmake skills-install, commitSKILLS.txtandskills-lock.json.SKILLS.txt, runbunx skills remove <name> --global --yes, thenmake skills-lock.make skills-installto install from the committed lock.Written for commit 924dd6b. Summary will update on new commits.