Repository navigation
[Fix] parser: Accept whole-number floats for integer tool arguments - #43941
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 19, 2026
Jiminator
added a commit
that referenced
this pull request
Oct 21, 2026
Jiminator
added a commit
that referenced
this pull request
Oct 21, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tool schemas are passed to the response parser, an
integerargument written as a whole-number float like"3.0"is now cast to3instead of being left as the raw string.integeras any number with a zero fractional part, so3.0is a validintegervalue.jsonschema(Draft 7 and 2020-12 validators) and Pydantic v2 both accept it, and Pydantic returns3."3.5"),infandNaNstill fail theintegercast, so they fall through to the next declared type or stay raw, as before.CI States
Latest PR Test (Base): ✅ Run #39535859047
Latest PR Test (Extra): ❌ Run #39535858929
Latest PR Test (AMD ROCm 10): ❌ Run #39535858894