Repository navigation
[cherrypick from #36389] [LoRA] Let DP-attention LoRA run idle ranks and eager prefill (partial) - #41507
Open
yushengsu-thu wants to merge 69 commits into
Open
[cherrypick from #36389] [LoRA] Let DP-attention LoRA run idle ranks and eager prefill (partial)#41507yushengsu-thu wants to merge 69 commits into
yushengsu-thu wants to merge 69 commits into
Conversation
…s in exact-token preprocessing (#30368) (#40009) Signed-off-by: Zhuangcheng(Jesse) Gu <zcgu@connect.hku.hk> Co-authored-by: Zhuangcheng(Jesse) Gu <40918450+Chokoyo@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mick <mickjagger19@icloud.com>
…39915) (#40137) Signed-off-by: William Arnold <7565007+Aphoh@users.noreply.github.com> Co-authored-by: William Arnold <7565007+Aphoh@users.noreply.github.com> Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
guapisolo
requested review from
1am9trash,
AgainstEntropy,
Alisehen,
AniZpZ,
BBuf,
ByronHsu,
DarkSharpness,
Duyi-Wang,
Edwardf0t1,
FlamingoPg,
HydraQYH,
OrangeRedeng,
ShangmingCai,
YAMY1234,
b8zhong,
celve,
ch-wan,
fzyzcjy,
hebiao064,
hubertlu-tw,
ispobock,
kevin-mii,
kkHuang-amd,
mmangkad,
niehen6174,
ping1jing2,
rainj-me,
sogalin,
yichiche and
yizhang2077
as code owners
October 2, 2026 06:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port two hunks of #36389 to the
sglang-milesbranch: itsmanagers/scheduler_components/dp_attn.pyandlora/utils.pychanges. Without them, a LoRA server with--enable-dp-attentiondies on its first batch:AttributeError: 'EagerRunner' object has no attribute 'can_replay_locally'in_local_prefill_cuda_graph_vote. With LoRA the prefill runner is theEagerRunnerfallback, and the vote now returnsFalsefor it.ValueError: Unsupported forward mode: 4inget_batch_token_counts, from MoE-LoRA batch preparation. DP ranks without requests run IDLE batches, whichget_batch_token_countsandgenerate_sequence_lengthsnow accept.Port notes
dp_size == tp_sizerequirements. It overlaps withsglang-miles' own DP-attention MoE-LoRA path and conflicts in 7 files.--moe-dense-tp-size 1the server needs [cherrypick from #39379] [LoRA] Size dense row/column-parallel LoRA buffers from the base linear's real shard #41506 to finish CUDA graph capture first.Testing
test/registered/unit/lora/,test/registered/unit/managers/scheduler_components/test_dp_attn.py,test/registered/unit/managers/test_scheduler_hicache_events.pyandtest/registered/unit/managers/test_scheduler_chunked_req_gate.pyhave 177 passed with and without this PR. The 4 failures are identical.--tp 8 --dp 8 --enable-dp-attention --ep 8 --moe-dense-tp-size 1 --enable-dp-lm-head, triton MoE and LoRA backends, and a LoRA on the layer-0 dense MLP, on top of [cherrypick from #39379] [LoRA] Size dense row/column-parallel LoRA buffers from the base linear's real shard #41506:EagerRunnererror under the default prefill graph settings, and with the IDLE error under--cuda-graph-backend-prefill disabled.pre-commit runon the changed files passes.CI States
Latest PR Test (Base): ❌ Run #36483117678
Latest PR Test (Extra): ❌ Run #36483116907
Latest PR Test (AMD ROCm 10): ❌ Run #36483117405