support kimi 2.5/6 lora (logprob diff exist) - #25141
Merged
Merged
Conversation
nanjiangwill
requested review from
CatherineSue,
Fridge003,
JustinTong0323,
Ying1123,
ch-wan,
fzyzcjy,
hnyls2002,
ispobock,
lifuhuang,
merrymercy,
slin1237,
xiezhq-hermann and
yushengsu-thu
as code owners
May 13, 2026 06:19
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
these modification should be sent to sglang/main as well or it will becomse useless after we upgrade the sgl |
yueming-yuan
force-pushed
the
sglang-miles
branch
from
May 22, 2026 22:22
363403a to
71bda1a
Compare
yueming-yuan
requested review from
Qiaolin-Yu,
key4ng,
mickqian,
yhyang201 and
yuan-luo
as code owners
May 22, 2026 22:22
yushengsu-thu
approved these changes
May 25, 2026
Collaborator
|
the modification are almost lora related only python/sglang/srt/models/deepseek_common/deepseek_weight_loader.py is related to kimi2.5 base. We can consider if revert the kimi2.5 base related parts. To unblock kimi full-param and lora training support so I merge them first. |
This was referenced Jun 17, 2026
JessicaJiang-123
pushed a commit
to JessicaJiang-123/sglang
that referenced
this pull request
Jun 21, 2026
nanjiangwill
added a commit
to nanjiangwill/sglang
that referenced
this pull request
Jun 30, 2026
The persistent cached_a_proj and unconditional .detach().clone() were a workaround for q_a_proj / kv_a_proj_with_mqa landing in different chunks during chunked weight updates. The proper fix is on the sender side: pair the two halves before chunking so they always arrive in the same load_weights call. That fix is in radixark/miles#1361 (mirrors THUDM/slime#1532). With sender-side pairing in place, the cached_a_proj only ever needs to live for one load_weights call, matching the original upstream behavior.
yushengsu-thu
pushed a commit
that referenced
this pull request
Jun 30, 2026
nanjiangwill
added a commit
to nanjiangwill/sglang
that referenced
this pull request
Jul 7, 2026
yueming-yuan
pushed a commit
that referenced
this pull request
Jul 14, 2026
yueming-yuan
pushed a commit
that referenced
this pull request
Jul 25, 2026
…h/RL fixes (#25141, #29874, #31251) Squashes the two follow-up PRs into the MoE-LoRA base commit: both rewrite the mem_pool sharding helpers this commit introduces and cannot be applied independently. Rebased onto v0.5.16: - the shard probes keep v0.5.16's shared-MoE-over-full-TP carve-out at EP=1 (`is_shared_moe_module`) and only fall through to the probed shard for non-MoE modules; - #29874's `free_lora` is dropped -- v0.5.16 already releases the slot on unload through `LoRAMemoryPool.remove_lora()`, which additionally zeroes the buffers for graph-captured replay, so `lora_manager.unload` needs no second call; - #31831's expected_checksums check is likewise already upstream in `tp_worker.load_lora_adapter_from_tensors`. Co-authored-by: Ethan (Yusheng) Su <yushengsu@radixark.ai>
yueming-yuan
pushed a commit
that referenced
this pull request
Jul 25, 2026
…h/RL fixes (#25141, #29874, #31251) Squashes the two follow-up PRs into the MoE-LoRA base commit: both rewrite the mem_pool sharding helpers this commit introduces and cannot be applied independently. Rebased onto v0.5.16: - the shard probes keep v0.5.16's shared-MoE-over-full-TP carve-out at EP=1 (`is_shared_moe_module`) and only fall through to the probed shard for non-MoE modules; - #29874's `free_lora` is dropped -- v0.5.16 already releases the slot on unload through `LoRAMemoryPool.remove_lora()`, which additionally zeroes the buffers for graph-captured replay, so `lora_manager.unload` needs no second call; - #31831's expected_checksums check is likewise already upstream in `tp_worker.load_lora_adapter_from_tensors`. Co-authored-by: Ethan (Yusheng) Su <yushengsu@radixark.ai>
yueming-yuan
pushed a commit
that referenced
this pull request
Jul 25, 2026
…h/RL fixes (#25141, #29874, #31251) Squashes the two follow-up PRs into the MoE-LoRA base commit: both rewrite the mem_pool sharding helpers this commit introduces and cannot be applied independently. Rebased onto v0.5.16: - the shard probes keep v0.5.16's shared-MoE-over-full-TP carve-out at EP=1 (`is_shared_moe_module`) and only fall through to the probed shard for non-MoE modules; - #29874's `free_lora` is dropped -- v0.5.16 already releases the slot on unload through `LoRAMemoryPool.remove_lora()`, which additionally zeroes the buffers for graph-captured replay, so `lora_manager.unload` needs no second call; - #31831's expected_checksums check is likewise already upstream in `tp_worker.load_lora_adapter_from_tensors`. Co-authored-by: Ethan (Yusheng) Su <yushengsu@radixark.ai>
yueming-yuan
pushed a commit
that referenced
this pull request
Jul 25, 2026
…h/RL fixes (#25141, #29874, #31251) Squashes the two follow-up PRs into the MoE-LoRA base commit: both rewrite the mem_pool sharding helpers this commit introduces and cannot be applied independently. Rebased onto v0.5.16: - the shard probes keep v0.5.16's shared-MoE-over-full-TP carve-out at EP=1 (`is_shared_moe_module`) and only fall through to the probed shard for non-MoE modules; - #29874's `free_lora` is dropped -- v0.5.16 already releases the slot on unload through `LoRAMemoryPool.remove_lora()`, which additionally zeroes the buffers for graph-captured replay, so `lora_manager.unload` needs no second call; - #31831's expected_checksums check is likewise already upstream in `tp_worker.load_lora_adapter_from_tensors`. Co-authored-by: Ethan (Yusheng) Su <yushengsu@radixark.ai>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Kimi K2.5 / K2.6 LoRA support to the `sglang-miles` branch:
`logprob diff exist` in the title flags a residual `train/train_rollout_logprob_abs_diff` drift seen on K2.5 RL runs;
Decomposition for `main`: #28562, #28564, #28566. The MoE post-process LoRA-wrapper skip is blocked on #28565 (upstream prereq). The MLA fused-A cache change is being reverted on `sglang-miles` via #28561.