Skip to content

support kimi 2.5/6 full param and lora - #1057

Closed
nanjiangwill wants to merge 2 commits into
radixark:mainfrom
nanjiangwill:kimi25
Closed

support kimi 2.5/6 full param and lora#1057
nanjiangwill wants to merge 2 commits into
radixark:mainfrom
nanjiangwill:kimi25

Conversation

@nanjiangwill

@nanjiangwill nanjiangwill commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

thanks @GeLee-Q for kimi 2.5 full param support

sglang-miles: sgl-project/sglang#25141
megatron-bridge: radixark/Megatron-Bridge#3

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Kimi VL and Kimi K2.5 models, including specialized weight conversion logic and multimodal token expansion for training. It significantly enhances the LoRA weight synchronization mechanism by implementing IPC staging buffers for faster transfers and a chunked streaming approach to handle large adapters with SGLang. Additionally, it adds support for shared-outer grouped-expert LoRA and updates various utility functions and quantization scripts to accommodate vision-tower and projector components. Feedback was provided to improve the robustness of rollout batch processing by using strict zipping.

Comment thread miles/backends/training_utils/data.py
@yushengsu-thu yushengsu-thu self-assigned this Apr 30, 2026
@yushengsu-thu

Copy link
Copy Markdown
Collaborator

@yushengsu-thu

Copy link
Copy Markdown
Collaborator

@gongyisheng - weight sync in this PR.

@yushengsu-thu

yushengsu-thu commented May 22, 2026

Copy link
Copy Markdown
Collaborator

@yushengsu-thu yushengsu-thu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblock the ci test

Comment thread miles/utils/memory_utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants