Revert deepseek_weight_loader.py changes from #25141 - #28561
Merged
yushengsu-thu merged 1 commit intoJun 30, 2026
Merged
Conversation
nanjiangwill
requested review from
Fridge003,
ch-wan,
fzyzcjy and
ispobock
as code owners
June 17, 2026 21:32
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
yueming-yuan
force-pushed
the
sglang-miles
branch
from
June 18, 2026 21:02
1dbbf3a to
6a4ffcc
Compare
yueming-yuan
requested review from
CatherineSue,
JustinTong0323,
Qiaolin-Yu,
ShangmingCai,
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
hzh0425,
jybsuper,
key4ng,
kpham-sgl,
lifuhuang,
merrymercy,
mickqian,
pyc96,
slin1237,
xiezhq-hermann,
yhyang201,
yizhang2077,
yuan-luo and
yushengsu-thu
as code owners
June 18, 2026 21:02
yueming-yuan
requested review from
AniZpZ,
BBuf,
ByronHsu,
Edwardf0t1,
FlamingoPg,
HaiShaw,
Kangyan-Zhou,
b8zhong,
bingxche,
hebiao064 and
sogalin
as code owners
June 18, 2026 21:02
The persistent cached_a_proj and unconditional .detach().clone() were a workaround for q_a_proj / kv_a_proj_with_mqa landing in different chunks during chunked weight updates. The proper fix is on the sender side: pair the two halves before chunking so they always arrive in the same load_weights call. That fix is in radixark/miles#1361 (mirrors THUDM/slime#1532). With sender-side pairing in place, the cached_a_proj only ever needs to live for one load_weights call, matching the original upstream behavior.
nanjiangwill
force-pushed
the
revert-deepseek-loader-25141
branch
from
June 30, 2026 06:09
2830e3f to
18f96d9
Compare
yushengsu-thu
approved these changes
Jun 30, 2026
yushengsu-thu
merged commit Jun 30, 2026
c855d1b
into
sgl-project:sglang-miles
37 of 42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why revert on `sglang-miles` and not main
Test plan
CI States
Latest PR Test (Base): ❌ Run #28424125993
Latest PR Test (Extra): ❌ Run #28424125889