[AMD] upd aiter: v0.1.10.post1

[HaiShaw]

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments or contact authorized users to do so.
   • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
4. After green CI and required approvals, ask Merge Oncalls to merge.

[gemini-code-assist]

Summary of Changes

Hello @HaiShaw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the AITER_COMMIT environment variable within the rocm.Dockerfile. This change ensures that the Docker build process utilizes the specified newer version of the aiter dependency, which is crucial for maintaining compatibility and incorporating the latest features or fixes from the aiter library into the ROCm build environment.

Highlights

• AITER_COMMIT Version Update: The AITER_COMMIT environment variable in the ROCm Dockerfile has been updated from v0.1.9.post1 to v0.1.10.post1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[HaiShaw]

/tag-and-rerun-ci

[gemini-code-assist]

Code Review

This pull request updates the AITER_COMMIT version from v0.1.9.post1 to v0.1.10.post1 in docker/rocm.Dockerfile. The change is applied to both the gfx942 and gfx950 build stages. The change is correct, and I've added a comment regarding the duplication of the version string, with a suggestion for a future refactoring to improve maintainability.

[gemini-code-assist]

While this version update is correct, the AITER_COMMIT variable is duplicated on line 34. This duplication makes version updates error-prone as one might forget to update both places.

To improve maintainability, you could define this version as an ARG at the top of the file and reuse it in both build stages. For example:

# At the top of the file, e.g., after line 14
ARG AITER_COMMIT_VERSION="v0.1.10.post1"

# ... later in the gfx942 stage
ENV AITER_COMMIT=${AITER_COMMIT_VERSION}

# ... and in the gfx950 stage
ENV AITER_COMMIT=${AITER_COMMIT_VERSION}

This would centralize the version string, making future updates easier and safer.

Note: The script scripts/ci/amd/amd_ci_install_dependency.sh currently parses the AITER_COMMIT value directly from this ENV line. If you apply this refactoring, the script would also need to be updated to handle the new variable substitution.

Since this refactoring is outside the scope of the current changes, it can be addressed in a follow-up PR.

[hnyls2002]

Hi @HaiShaw, this one is stale -- docker/rocm.Dockerfile no longer pins AITER_COMMIT to a version tag; it now uses a commit SHA via AITER_COMMIT_DEFAULT, and several later AITER upgrades (e.g. #27555, #27376) have already merged. Closing as obsolete; reopen if I missed something.