[AMD] update ROCm AITER commit#27376
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review
This pull request updates the default commit hash for AITER_COMMIT_DEFAULT across multiple stages in docker/rocm.Dockerfile. The reviewer suggests refactoring the Dockerfile to define this variable as a global ARG at the top of the file, which would eliminate duplication and make future updates less error-prone.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ENV BUILD_AITER_ALL="1" | ||
| ENV BUILD_MOONCAKE="1" | ||
| ENV AITER_COMMIT_DEFAULT="46e6c92b3eb33f64823aaa1ff39a14586b059ef5" | ||
| ENV AITER_COMMIT_DEFAULT="6740fb7911db231e6eadad45194ad6713d25f9fb" |
There was a problem hiding this comment.
The environment variable AITER_COMMIT_DEFAULT is duplicated across all four base image stages (lines 34, 44, 54, and 64). This duplication makes updates error-prone and harder to maintain.
Consider defining AITER_COMMIT_DEFAULT once as a global ARG at the top of the Dockerfile (before the first FROM instruction) and then referencing it in the final stage. This allows you to manage the default commit in a single place.
Suggested Refactoring
- At the very top of the
Dockerfile(before the firstFROM):
ARG AITER_COMMIT_DEFAULT="6740fb7911db231e6eadad45194ad6713d25f9fb"- In the final stage (around line 86):
ARG AITER_COMMIT_DEFAULT
ARG AITER_COMMIT=""
ENV AITER_COMMIT="${AITER_COMMIT:-${AITER_COMMIT_DEFAULT}}"- Remove the
ENV AITER_COMMIT_DEFAULTlines from the base stages (gfx942,gfx942-rocm720,gfx950, andgfx950-rocm720).
Summary
CI States
Latest PR Test (Base): ✅ Run #27009642287
Latest PR Test (Extra): ❌ Run #27009642114