Skip to content

[AMD] update ROCm AITER commit#27376

Merged
HaiShaw merged 1 commit into
mainfrom
rocm-aiter-6740fb7
Jun 5, 2026
Merged

[AMD] update ROCm AITER commit#27376
HaiShaw merged 1 commit into
mainfrom
rocm-aiter-6740fb7

Conversation

@bingxche

@bingxche bingxche commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update the default ROCm Dockerfile AITER commit to 6740fb7911db231e6eadad45194ad6713d25f9fb for all ROCm image targets.

CI States

Latest PR Test (Base): ✅ Run #27009642287
Latest PR Test (Extra): ❌ Run #27009642114

Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default commit hash for AITER_COMMIT_DEFAULT across multiple stages in docker/rocm.Dockerfile. The reviewer suggests refactoring the Dockerfile to define this variable as a global ARG at the top of the file, which would eliminate duplication and make future updates less error-prone.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/rocm.Dockerfile
ENV BUILD_AITER_ALL="1"
ENV BUILD_MOONCAKE="1"
ENV AITER_COMMIT_DEFAULT="46e6c92b3eb33f64823aaa1ff39a14586b059ef5"
ENV AITER_COMMIT_DEFAULT="6740fb7911db231e6eadad45194ad6713d25f9fb"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The environment variable AITER_COMMIT_DEFAULT is duplicated across all four base image stages (lines 34, 44, 54, and 64). This duplication makes updates error-prone and harder to maintain.

Consider defining AITER_COMMIT_DEFAULT once as a global ARG at the top of the Dockerfile (before the first FROM instruction) and then referencing it in the final stage. This allows you to manage the default commit in a single place.

Suggested Refactoring

  1. At the very top of the Dockerfile (before the first FROM):
ARG AITER_COMMIT_DEFAULT="6740fb7911db231e6eadad45194ad6713d25f9fb"
  1. In the final stage (around line 86):
ARG AITER_COMMIT_DEFAULT
ARG AITER_COMMIT=""
ENV AITER_COMMIT="${AITER_COMMIT:-${AITER_COMMIT_DEFAULT}}"
  1. Remove the ENV AITER_COMMIT_DEFAULT lines from the base stages (gfx942, gfx942-rocm720, gfx950, and gfx950-rocm720).

@HaiShaw HaiShaw merged commit 8c82818 into main Jun 5, 2026
93 of 97 checks passed
@HaiShaw HaiShaw deleted the rocm-aiter-6740fb7 branch June 5, 2026 10:42
edwingao28 pushed a commit to edwingao28/sglang that referenced this pull request Jun 7, 2026
monkeyLoveding pushed a commit to monkeyLoveding/sglang_open that referenced this pull request Jun 9, 2026
@hnyls2002 hnyls2002 mentioned this pull request Jun 12, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants