Skip to content

[AMD] upd aiter: v0.1.10.post1 #18106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HaiShaw wants to merge 1 commit into from
+2 −2
Closed

[AMD] upd aiter: v0.1.10.post1 #18106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/rocm.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ENV BUILD_TRITON="0"
ENV BUILD_LLVM="0"
ENV BUILD_AITER_ALL="1"
ENV BUILD_MOONCAKE="1"
ENV AITER_COMMIT="v0.1.9.post1"
ENV AITER_COMMIT="v0.1.10.post1"

@gemini-code-assist gemini-code-assist Bot Feb 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this version update is correct, the AITER_COMMIT variable is duplicated on line 34. This duplication makes version updates error-prone as one might forget to update both places.

To improve maintainability, you could define this version as an ARG at the top of the file and reuse it in both build stages. For example:

# At the top of the file, e.g., after line 14
ARG AITER_COMMIT_VERSION="v0.1.10.post1"

# ... later in the gfx942 stage
ENV AITER_COMMIT=${AITER_COMMIT_VERSION}

# ... and in the gfx950 stage
ENV AITER_COMMIT=${AITER_COMMIT_VERSION}

This would centralize the version string, making future updates easier and safer.

Note: The script scripts/ci/amd/amd_ci_install_dependency.sh currently parses the AITER_COMMIT value directly from this ENV line. If you apply this refactoring, the script would also need to be updated to handle the new variable substitution.

Since this refactoring is outside the scope of the current changes, it can be addressed in a follow-up PR.


# ===============================
# Base image 950 and args
Expand All @@ -31,7 +31,7 @@ ENV BUILD_TRITON="0"
ENV BUILD_LLVM="0"
ENV BUILD_AITER_ALL="0"
ENV BUILD_MOONCAKE="1"
ENV AITER_COMMIT="v0.1.9.post1"
ENV AITER_COMMIT="v0.1.10.post1"
# ===============================
# Chosen arch and args
FROM ${GPU_ARCH}
Expand Down
Loading