Conversation
Summary of ChangesHello @Fridge003, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the FlashInfer library to version 0.6.0 across the project's configuration and dependency management files. This essential upgrade ensures that the project is aligned with the latest FlashInfer release, which is a prerequisite for several other pending pull requests and helps maintain compatibility and leverage new optimizations from the library. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the flashinfer dependency to version 0.6.0. The changes are consistent across the Dockerfile, Python project dependencies, runtime version assertions, and CI installation scripts. My review includes one suggestion to improve maintainability by centralizing the version number.
|
/tag-and-rerun-ci again |
5277493 to
db2266a
Compare
elvischenv
left a comment
There was a problem hiding this comment.
The Flashinfer MoE API breakage changes(remove tile_tokens_dim) should come together with this PR, otherwise the tests using Flashinfer MoE will fail.
|
We are currently blocked at the update of FA4 #15182 |
65411d4 to
a0421af
Compare
|
Just checking this failing case: https://github.com/sgl-project/sglang/actions/runs/21020274512/job/60599048636?pr=15551(Seems to be the only non flaky test) Seems the behavior of In 0.5.3, it will be dispatched to
While in 0.6.1, it will be dispatched to As a workaround, I will set fa3 as the default backend for Mixtral model to unblock CI. My commands for profiling: |
|
/rerun-stage performance-test-2-gpu |
|
✅ Triggered |
|
/rerun-stage unit-test-backend-4-gpu-gb200 |
|
✅ Triggered |
Not only mixtral, Qwen 3 235B bandwidth collapsed on flashinfer |
|
@Fridge003 |




Motivation
flashinfer -> 0.6.1
flashinfer-cubin -> 0.6.1
PRs dependent on this upgrade:
#15546
#15422
#15514
#15347
#14668
#16232
#16279
#16892
#16534
#12787
...
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist