[Perf] Support Flashinfer RoPE+Quant+KV update kernel for trtllm_mha backend for GPT-OSS#15729
Open
elvischenv wants to merge 3 commits intosgl-project:mainfrom
Open
[Perf] Support Flashinfer RoPE+Quant+KV update kernel for trtllm_mha backend for GPT-OSS#15729elvischenv wants to merge 3 commits intosgl-project:mainfrom
elvischenv wants to merge 3 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
11 tasks
5e5c50f to
7cc00cb
Compare
7cc00cb to
191dcf2
Compare
191dcf2 to
e59267f
Compare
Collaborator
|
This can be reviewed together with #19451 . They are very similar, except that one is for trtllm_mha and one is for trtllm_mla |
5 tasks
Collaborator
|
For the accuracy results, which model are you testing on? |
Fridge003
reviewed
Mar 24, 2026
| return None | ||
|
|
||
| def support_rope_fusion(self) -> bool: | ||
| """Check if the current backend supports RoPE fusion.""" |
Collaborator
There was a problem hiding this comment.
Instead of adding this method in base class, can we control this fusion with an environ flag?
Now it is set to False by default. After this feature stabilizes it can be turned on by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to support Flashinfer
rope_quantize_fp8_append_paged_kv_cachekernel for trtllm_mha backend and enable it on GPT-OSS.Depends on Flashinfer 0.6.0: #15551
Accuracy
PR
main
Perf (GPT-OSS-120b TP8 con8)
PR: 5.5% perf gain
main
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist