[depend on flashinfer 0.6.0) change mm_fp4 to auto for cu13#16232
[depend on flashinfer 0.6.0) change mm_fp4 to auto for cu13#16232vincentzed wants to merge 1 commit intosgl-project:mainfrom
Conversation
Summary of ChangesHello @vincentzed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on optimizing FP4 GEMM (General Matrix Multiply) operations by integrating the latest features from FlashInfer 0.6.0. The core change introduces an intelligent, automatic backend selection for FP4 GEMM, specifically targeting CUDA 13 environments. This enhancement aims to improve performance and efficiency by leveraging the most suitable underlying library (cuDNN or Cutlass) for matrix multiplications, without requiring manual configuration, thereby streamlining the execution of quantized models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the mm_fp4 backend selection to use auto for CUDA 13, which is a good improvement that leverages new features in flashinfer. The refactoring to centralize the backend selection logic into a new function, resolve_mm_fp4_gemm_backend, improves code clarity and maintainability. I have one suggestion to further simplify this new function to reduce code duplication. Overall, the changes are well-structured and align with the goals of the pull request.
| if _IS_CUDA_13: | ||
| # auto resolution: if cudnn < 9.15, use cutlass else use cudnn | ||
| # https://github.com/flashinfer-ai/flashinfer/pull/1979 | ||
| backend = FLASHINFER_FP4_GEMM_BACKEND if FLASHINFER_FP4_GEMM_BACKEND else "auto" | ||
| else: | ||
| backend = ( | ||
| FLASHINFER_FP4_GEMM_BACKEND if FLASHINFER_FP4_GEMM_BACKEND else "cutlass" | ||
| ) | ||
| return backend |
There was a problem hiding this comment.
This function can be simplified to avoid repeating the check for FLASHINFER_FP4_GEMM_BACKEND. By checking for the user-specified backend first, you can reduce code duplication and make the logic more straightforward.
| if _IS_CUDA_13: | |
| # auto resolution: if cudnn < 9.15, use cutlass else use cudnn | |
| # https://github.com/flashinfer-ai/flashinfer/pull/1979 | |
| backend = FLASHINFER_FP4_GEMM_BACKEND if FLASHINFER_FP4_GEMM_BACKEND else "auto" | |
| else: | |
| backend = ( | |
| FLASHINFER_FP4_GEMM_BACKEND if FLASHINFER_FP4_GEMM_BACKEND else "cutlass" | |
| ) | |
| return backend | |
| if FLASHINFER_FP4_GEMM_BACKEND: | |
| return FLASHINFER_FP4_GEMM_BACKEND | |
| if _IS_CUDA_13: | |
| # auto resolution: if cudnn < 9.15, use cutlass else use cudnn | |
| # https://github.com/flashinfer-ai/flashinfer/pull/1979 | |
| return "auto" | |
| return "cutlass" |
|
Before: After: |
|
This change will be covered in #16534 |
Motivation
flashinfer-ai/flashinfer#1979 enables auto for mm_fp4, so we should use it for cu13 (except in the case that user specify flashinfer mm fp4 backend).
If cudnn>=9.15, then we should use cudnn. It is faster
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.