[Fix] A followup fix for TRTLLM BF16 MoE#15303
Merged
Fridge003 merged 3 commits intosgl-project:mainfrom Feb 27, 2026
Merged
Conversation
samuellees
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
b8zhong
approved these changes
Dec 17, 2025
Collaborator
|
/tag-and-rerun-ci agai |
Collaborator
|
@samuellees Can you fix the merge conflict? |
Fridge003
approved these changes
Dec 23, 2025
Collaborator
|
@samuellees Can you take a look at this failure |
samuellees
force-pushed
the
fix-ds-break-followup
branch
from
b88a0a1 to
112730c
Compare
Contributor
Author
|
/tag-and-rerun-ci |
3 similar comments
Contributor
Author
|
/tag-and-rerun-ci |
Contributor
Author
|
/tag-and-rerun-ci |
Contributor
Author
|
/tag-and-rerun-ci |
ybalbert001
pushed a commit
to ybalbert001/sglang
that referenced
this pull request
Feb 28, 2026
…n format This PR updates the Grafana dashboard to use the new Prometheus metrics naming convention introduced in PR sgl-project#15303. Changes: - Replace `sglang_` prefix with `sglang:` namespace format in all 14 metric references in the dashboard JSON The colon format (namespace:metric_name) is the Prometheus recommended convention for namespacing metrics. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5 tasks
magicYang1573
pushed a commit
to magicYang1573/sglang
that referenced
this pull request
Mar 9, 2026
5 tasks
4 tasks
karanb192
pushed a commit
to karanb192/sglang
that referenced
this pull request
Mar 18, 2026
Since PR sgl-project#15303, Prometheus metrics use colon namespace format (sglang:metric_name) instead of underscore format (sglang_metric_name). Update all 14 metric references in the Grafana dashboard JSON to use the colon format so dashboard panels display data correctly. Fixes sgl-project#20752 Signed-off-by: karanb192 <karan@example.com>
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A followup fix for TRTLLM BF16 MoE, making code more robust.
See PR15002, and https://sgl-fru7574.slack.com/archives/C09NG5Q0LEP/p1765528804581049 for detials.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist