Fix Grafana dashboard metrics naming to match Prometheus colon format#20821
Open
karanb192 wants to merge 1 commit intosgl-project:mainfrom
Open
Fix Grafana dashboard metrics naming to match Prometheus colon format#20821karanb192 wants to merge 1 commit intosgl-project:mainfrom
karanb192 wants to merge 1 commit intosgl-project:mainfrom
Conversation
Since PR sgl-project#15303, Prometheus metrics use colon namespace format (sglang:metric_name) instead of underscore format (sglang_metric_name). Update all 14 metric references in the Grafana dashboard JSON to use the colon format so dashboard panels display data correctly. Fixes sgl-project#20752 Signed-off-by: karanb192 <karan@example.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Author
|
Hi maintainers, could you please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/monitoring/grafana/dashboards/json/sglang-dashboard.json) from underscore format (sglang_metric_name) to colon namespace format (sglang:metric_name)Affected Metrics (6 metrics, 14 references)
sglang_e2e_request_latency_seconds_*sglang:e2e_request_latency_seconds_*sglang_time_to_first_token_seconds_*sglang:time_to_first_token_seconds_*sglang_num_running_reqssglang:num_running_reqssglang_gen_throughputsglang:gen_throughputsglang_cache_hit_ratesglang:cache_hit_ratesglang_num_queue_reqssglang:num_queue_reqsFixes #20752
Test Plan
examples/monitoring/)python/sglang/srt/metrics/collector.pydefinitions