Skip to content

[Fix] Update Grafana dashboard metrics naming from underscore to colon format#19556

Open
ybalbert001 wants to merge 2 commits intosgl-project:mainfrom
ybalbert001:fix/grafana-dashboard-metrics-naming
Open

[Fix] Update Grafana dashboard metrics naming from underscore to colon format#19556
ybalbert001 wants to merge 2 commits intosgl-project:mainfrom
ybalbert001:fix/grafana-dashboard-metrics-naming

Conversation

@ybalbert001
Copy link

@ybalbert001 ybalbert001 commented Feb 28, 2026

@zhaochenyang20 @kebe7jun could you help review this PR? I noticed you have involved in the #47

This PR updates the Grafana dashboard to use the new Prometheus metrics naming convention introduced in PR #15303.

Changes:

  • Replace sglang_ prefix with sglang: namespace format in all 14 metric references in the dashboard JSON

The colon format (namespace:metric_name) is the Prometheus recommended convention for namespacing metrics.

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

…n format

This PR updates the Grafana dashboard to use the new Prometheus metrics
naming convention introduced in PR sgl-project#15303.

Changes:
- Replace `sglang_` prefix with `sglang:` namespace format in all 14 metric
  references in the dashboard JSON

The colon format (namespace:metric_name) is the Prometheus recommended
convention for namespacing metrics.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures consistency in metric naming within the Grafana dashboard by adopting the Prometheus recommended namespace:metric_name format. This change reflects a prior update to the backend metrics, improving adherence to best practices for monitoring and making the dashboard compatible with the updated metric structure.

Highlights

  • Metric Naming Convention Update: The Grafana dashboard has been updated to align with the new Prometheus metric naming convention, replacing the sglang_ prefix with the sglang: namespace format across all 14 metric references.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/monitoring/grafana/dashboards/json/sglang-dashboard.json
    • Replaced sglang_e2e_request_latency_seconds_bucket with sglang:e2e_request_latency_seconds_bucket in multiple expressions.
    • Replaced sglang_e2e_request_latency_seconds_sum and sglang_e2e_request_latency_seconds_count with their colon-separated equivalents.
    • Updated sglang_time_to_first_token_seconds_bucket, sglang_time_to_first_token_seconds_sum, and sglang_time_to_first_token_seconds_count to use the sglang: namespace.
    • Changed sglang_num_running_reqs to sglang:num_running_reqs.
    • Modified sglang_gen_throughput to sglang:gen_throughput.
    • Updated sglang_cache_hit_rate to sglang:cache_hit_rate.
    • Replaced sglang_num_queue_reqs with sglang:num_queue_reqs.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Grafana dashboard to use the new Prometheus metrics naming convention, replacing the sglang_ prefix with the sglang: namespace. The changes are consistent across all 14 metric references in the sglang-dashboard.json file. This aligns the dashboard with the updated metric names defined in the codebase and follows Prometheus best practices for metric naming. The changes are correct and complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant