[Fix] Update Grafana dashboard metrics naming from underscore to colon format#19556
[Fix] Update Grafana dashboard metrics naming from underscore to colon format#19556ybalbert001 wants to merge 2 commits intosgl-project:mainfrom
Conversation
…n format This PR updates the Grafana dashboard to use the new Prometheus metrics naming convention introduced in PR sgl-project#15303. Changes: - Replace `sglang_` prefix with `sglang:` namespace format in all 14 metric references in the dashboard JSON The colon format (namespace:metric_name) is the Prometheus recommended convention for namespacing metrics. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ensures consistency in metric naming within the Grafana dashboard by adopting the Prometheus recommended Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Grafana dashboard to use the new Prometheus metrics naming convention, replacing the sglang_ prefix with the sglang: namespace. The changes are consistent across all 14 metric references in the sglang-dashboard.json file. This aligns the dashboard with the updated metric names defined in the codebase and follows Prometheus best practices for metric naming. The changes are correct and complete.
@zhaochenyang20 @kebe7jun could you help review this PR? I noticed you have involved in the #47
This PR updates the Grafana dashboard to use the new Prometheus metrics naming convention introduced in PR #15303.
Changes:
sglang_prefix withsglang:namespace format in all 14 metric references in the dashboard JSONThe colon format (namespace:metric_name) is the Prometheus recommended convention for namespacing metrics.
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci