Skip to content

Revert " Build the deepep package with the chip model included."#363

Merged
Yael-X merged 1 commit intosgl-project:mainfrom
kaniel-outis:revert-274-build_a2_a3
Feb 4, 2026
Merged

Revert " Build the deepep package with the chip model included."#363
Yael-X merged 1 commit intosgl-project:mainfrom
kaniel-outis:revert-274-build_a2_a3

Conversation

@kaniel-outis
Copy link
Copy Markdown
Contributor

Reverts #274

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kaniel-outis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of a previous change that introduced NPU chip model detection and integration into the deepep package's build process. The primary impact is the removal of code responsible for identifying specific NPU hardware and incorporating that information into the package version, streamlining the build configuration by eliminating hardware-specific versioning.

Highlights

  • NPU Chip Model Detection Removal: The logic responsible for detecting the NPU chip type (e.g., 910B, 910C) using the npu-smi command has been entirely removed from the setup.py script.
  • Version Suffix Simplification: The package version suffix no longer includes chip-specific information, simplifying the overall versioning scheme for the deepep package.
  • Build System Import Adjustment: The setuptools import statement was updated to include find_namespace_packages alongside find_packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/deep_ep/setup.py
    • Removed the sys module import.
    • Updated the setuptools import statement to include find_namespace_packages.
    • Deleted the get_npu_chip_type function and all associated calls and logic for determining and applying a chip-specific suffix to the package version.
Activity
  • This pull request is a direct revert of sgl-project/sgl-kernel-npu#274, indicating a decision to undo previously merged changes.
  • No further activity (comments, reviews, or progress updates) has been provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the changes from a previous commit that added logic to include the NPU chip model in the package version. The revert correctly removes the get_npu_chip_type function and its usage in constructing the version suffix. I have one minor suggestion to clean up an unused import that seems to have been introduced as part of this change. Otherwise, the revert looks correct.

@Yael-X Yael-X merged commit 645ffce into sgl-project:main Feb 4, 2026
5 checks passed
zhuyutong332 added a commit to zhuyutong332/sgl-kernel-npu that referenced this pull request Feb 5, 2026
* upstream/main:
  reset ci -- run test mixed running for experts on a2. (sgl-project#365)
  Revert "Build the deepep package with the chip model included. (sgl-project#274)" (sgl-project#363)
  fix:buffer control (sgl-project#361)
  Build the deepep package with the chip model included. (sgl-project#274)
  bugfix wrong packages build dir (sgl-project#360)
  bump version to 2026.02.01 (sgl-project#359)
1329009851 added a commit to 1329009851/sgl-kernel-npu that referenced this pull request Feb 11, 2026
…-npu into sgl-cmake2

* 'sgl-cmake2' of https://github.com/1329009851/sgl-kernel-npu:
  CI execution requirements for separating a2 and a3 (sgl-project#367)
  Fix the bug that total expert num greater than 256 or local expert num is less than 8 (sgl-project#364)
  adapt ant moving to A2 single machine (sgl-project#362)
  reset ci -- run test mixed running for experts on a2. (sgl-project#365)
  Revert "Build the deepep package with the chip model included. (sgl-project#274)" (sgl-project#363)
  fix:buffer control (sgl-project#361)
  Build the deepep package with the chip model included. (sgl-project#274)
  bugfix wrong packages build dir (sgl-project#360)
  bump version to 2026.02.01 (sgl-project#359)
  Cover the workflows cases on a3 (sgl-project#321)
  release follows naming convention (sgl-project#356)
  Modify notifydispatch to support DEEPEP_NORMAL_LONG_SEQ_ROUND up to 128. (sgl-project#352)
  fix the hanging bug (sgl-project#355)
  [Bugfix] Fix build script working with cann 8.5.0 (sgl-project#354)
  Modify the description of DeepEP in the README file. (sgl-project#348)
  Revert "Add scripts for building CMake files (sgl-project#344)" (sgl-project#353)
  Add scripts for building CMake files (sgl-project#344)
  Support x86_64 and aarch64 binary release (sgl-project#325)
  add function for deep-ep tests (sgl-project#301)
  [Doc] Improved README.md content and English grammar and integrated the DeepWiki badge for Ask AI (sgl-project#345)
zzx-study pushed a commit to zzx-study/sgl-kernel-npu that referenced this pull request Feb 28, 2026
AndyKong2020 pushed a commit to AndyKong2020/sgl-kernel-npu that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants