fix the hanging bug

[luanyundu]

the performance is below

bs	disable GB/s	enable GB/s
4096	92.25	106.17
8192	98.38	105.47
16384	-	108.84
32768	-	109.30

[gemini-code-assist]

Summary of Changes

Hello @luanyundu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a hanging bug and enhances the performance of MoE operations, especially when dealing with larger batch sizes. The core changes involve increasing the maximum allowed batch size and refining the multi-round processing logic to ensure proper synchronization and data handling, which is crucial for stable and efficient execution.

Highlights

• Batch Size Limit Increase: The BS_UPPER_BOUND constant has been doubled from 32768 to 65536 in cam_moe_combine_normal_tiling.cc and cam_moe_dispatch_normal_tiling.cc, allowing for processing of larger batch sizes.
• Multi-Round Processing Logic Refactor: The Process method in cam_moe_combine_normal_multi_round.h has been refactored to reorder buffer copy/read operations and conditionally execute synchronization steps (SetRoundStatus, WaitRoundStatus, SyncAll) only when realRound > 1. This change likely addresses the hanging bug and improves multi-round execution stability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a hanging bug and improves performance, as indicated by the provided benchmark data. The changes involve increasing the BS_UPPER_BOUND constant in two tiling configuration files to support larger batch sizes and a significant reordering of synchronization logic within the CamMoeCombineNormalMultiRound::Process method. The reordering of operations in the Process method appears to be a well-considered fix, ensuring buffer operations are performed consistently before conditional inter-round synchronization.