Build the deepep package with the chip model included.

[oagniqgnat]

Build the deepep package with the chip model included.

[gemini-code-assist]

Summary of Changes

Hello @oagniqgnat, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the deepep package build process by dynamically detecting the NPU chip model (Ascend 910B or 910C) during setup. This detected chip information is then appended to the package's version string, providing clearer identification of the target hardware for which the package was built. This change aims to improve compatibility and version management for different NPU environments.

Highlights

• NPU Chip Type Detection: A new function, get_npu_chip_type, has been introduced in setup.py to programmatically detect the NPU chip model (Ascend 910B or 910C) by executing the npu-smi command. This function includes robust error handling for cases where npu-smi is not found or fails.
• Enhanced Package Versioning: The detected NPU chip type is now incorporated into the deepep package's version suffix. This ensures that the built package explicitly indicates the target chip model (e.g., _910B or _910C), improving clarity and compatibility for different NPU environments.
• Dependency Cleanup: The unused find_namespace_packages import has been removed from setup.py, streamlining the build script.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the packaging process to include the NPU chip model in the version string. The main change is in setup.py, where a new function get_npu_chip_type is introduced to detect the chip model by executing the npu-smi command. My review identified a couple of areas for improvement. There is some redundant and unreachable code within the chip detection logic that should be removed. Additionally, a duplicated print statement was found in a test file, which appears to be an accidental addition. I've left specific comments with suggestions to address these points.