fix notify magic auto-increment bug

[zuje123]

fix notify magic auto-increment bug, AscendC::SetAtomicAdd not support uint64_t, that's why magic failed to auto-increment, duplicate flag values.
The sglang bench results are as follows

[gemini-code-assist]

Summary of Changes

Hello @zuje123, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the auto-increment functionality within the NotifyDispatchA2 class, which is part of the deep learning operations kernel. The changes ensure that a 'magic' counter is incremented accurately by directly fetching its current value, adding one, and then updating it. This fix also streamlines the code by removing redundant atomic operation calls and introduces a memory barrier for robust synchronization, ultimately improving the reliability and correctness of the kernel's operations.

Highlights

• Corrected Auto-Increment Logic: The mechanism for incrementing the 'magic' value in NotifyDispatchA2 has been revised to correctly read the current value from magicTensor_, add one, and then write it back, resolving an auto-increment bug.
• Removed Redundant Atomic Operations: The calls to AscendC::SetAtomicAdd and AscendC::SetAtomicNone were removed as they were either incorrectly used or unnecessary for the intended increment logic, simplifying the code.
• Added Memory Synchronization Barrier: A PipeBarrier<PIPE_ALL>() has been introduced before the increment operation to ensure proper memory synchronization and visibility of magicTensor_'s value, preventing potential race conditions or stale data reads.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a bug in the auto-increment logic for the magic number. The change replaces an atomic add operation with a non-atomic read-modify-write. While this might address the original issue, the code still contains a critical bug where it copies uninitialized data from a local buffer, leading to memory corruption in global memory. I have provided a suggestion to fix this by properly initializing the buffer.