Optimize prepare_lens by removing device transfer#289
Optimize prepare_lens by removing device transfer#289iforgetmyname merged 2 commits intosgl-project:mainfrom
Conversation
Removed unnecessary device transfer for cu_seqlens in prepare_lens function.
Summary of ChangesHello @shengzhaotian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly optimizes the prepare_lens function by removing an unnecessary device transfer, which is a good performance improvement. I have added a comment with suggestions for further code cleanup and simplification that this change makes possible.
* upstream/main: optimize gdn gating and fused_qkvzba_split_reshape_cat (sgl-project#306) fix layout numTokensPerExpertTensor partial Initialization bug (sgl-project#303) Supplement A2 doc, software and hardware compatibility info (sgl-project#294) Added an environment variable to control whether to enable the Combine Ant Migration feature. (sgl-project#304) Support build with cann 8.5 (sgl-project#283) LoRA: Optimization LoRA kernels and refactoring (sgl-project#284) fix a2 single combine aclnn params Resolving the UB out-of-bounds issue caused by A2 dual-machine mixed operation (sgl-project#288) fix notify magic auto-increment bug (sgl-project#291) split_qkv_rmsnorm_rope bugfix (sgl-project#290) Optimize prepare_lens by removing device transfer (sgl-project#289)
…pu-old into bugfix * 'a3_topk-1' of https://github.com/luanyundu/sgl-kernel-npu-old: fix dispatch_layout to support topk -1 feature optimize gdn gating and fused_qkvzba_split_reshape_cat (sgl-project#306) fix layout numTokensPerExpertTensor partial Initialization bug (sgl-project#303) Supplement A2 doc, software and hardware compatibility info (sgl-project#294) Added an environment variable to control whether to enable the Combine Ant Migration feature. (sgl-project#304) Support build with cann 8.5 (sgl-project#283) LoRA: Optimization LoRA kernels and refactoring (sgl-project#284) fix a2 single combine aclnn params Resolving the UB out-of-bounds issue caused by A2 dual-machine mixed operation (sgl-project#288) fix notify magic auto-increment bug (sgl-project#291) split_qkv_rmsnorm_rope bugfix (sgl-project#290) Optimize prepare_lens by removing device transfer (sgl-project#289) Fix the performance degradation issue of the single-wheel operation in Ant Moving. (sgl-project#287) modify split_qkv_rmsnorm_rope (sgl-project#282)
* Optimize prepare_lens by removing device transfer Removed unnecessary device transfer for cu_seqlens in prepare_lens function. * Refactor prepare_lens to simplify tensor conversion
Removed unnecessary device transfer for cu_seqlens in prepare_lens function.