Resolving the UB out-of-bounds issue caused by A2 dual-machine mixed operation

[oagniqgnat]

Resolving the UB out-of-bounds issue caused by A2 dual-machine mixed operation

[gemini-code-assist]

Summary of Changes

Hello @oagniqgnat, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an out-of-bounds issue encountered during A2 dual-machine mixed operations by refining the memory allocation strategy within the MoE (Mixture of Experts) distribution and combination kernels. The changes involve reserving an additional 400MB for notification data and adjusting various buffer size calculations to ensure sufficient space, thereby preventing potential overflows and enhancing stability, particularly when dealing with highly unbalanced workloads.

Highlights

• Out-of-bounds Issue Resolution: Addresses a critical out-of-bounds (UB) issue specifically occurring during A2 dual-machine mixed operations, enhancing system stability.
• Buffer Size Adjustment: Introduces a new NOTIFY_DATA_SIZE constant (400MB) to explicitly reserve space for notification data within the MoE kernels.
• Memory Allocation Logic Update: Modifies buffer size calculations (specifically IPC_DATA_SIZE, winSizeMin, and RANK_SIZE_ON_IPC) in both moe_distribute_combine_v2_layered_custom.h and moe_distribute_dispatch_v2_layered_custom.h to prevent overflows, particularly under unbalanced load conditions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request resolves an out-of-bounds issue in MoE operations by reserving a 400MB buffer for 'notify data'. The changes correctly adjust various buffer size calculations (IPC_DATA_SIZE, winSizeMin, RANK_SIZE_ON_IPC) in both the combine and dispatch kernels to account for this new reserved space. The logic appears sound.

My main feedback is regarding the implementation of this change. The new constant NOTIFY_DATA_SIZE is duplicated in both kernel headers. I've suggested moving it to a shared header like moe_distribute_base.h to improve maintainability. I also recommended adding a comment to explain the purpose and origin of the 400MB size, as it's currently a magic number.