-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to "Whitelabel" #687
Conversation
Per the [SendGrid Docs](https://github.com/sendgrid/docs/blob/develop/content/docs/glossary/whitelabel.md), the term "whitelabel" is sunset and needs to be replaced with other words, even though the API still calls it Whitelabeling.
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 35 35
Lines 1156 1156
Branches 172 172
=======================================
Hits 980 980
Misses 90 90
Partials 86 86 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this extensive doc update!
Hello @crweiner, |
Closes #686
Checklist
Short description of what this PR does:
Per #686 and the SendGrid Docs here as well as an upcoming addition to the Docs in a PR I have submitted here, the term "Whitelabel" is no longer being used in SendGrid documentation and has been "deprecated" (see here), even though the API still references it.
This PR alters the references to whitelabeling and replaces them with the following:
Whitelabel = Sender Authentication
Domain Whitelabel = Domain Authentication
IP Whitelabel = Reverse DNS
Link Whitelabel = Link branding