Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

Creates Automating Subusers Page #4182

Merged
merged 10 commits into from
Oct 23, 2018
Merged

Creates Automating Subusers Page #4182

merged 10 commits into from
Oct 23, 2018

Conversation

crweiner
Copy link
Contributor

@crweiner crweiner commented Oct 11, 2018

## Do Not Merge Yet
Please review this PR and page to make sure that it meets what you were looking for before any merger. Please let me know any and all changes that need to be made and I will be happy to do so. Opening this up as a PR just makes it easier to share my Commits/edits and contributions with you so we can collaborate.
I will remove the [Do Not Merge] tag from the title once I get the thumbs up from you. 👍

Description of the change:
Per #4175, this PR creates a page called Automating Subusers and includes the curl references in proper Markdown, stylized for Github.

Closes #4175

```bash
=> 2xx

{"id":50784,"user_id":624781,"subdomain":"subdomain","domain":"staples.com","username":"ryan.burrer","ips":["167.89.38.39","198.37.152.144"],"custom_spf":false,"default":true,"legacy":false,"automatic_security":true,"valid":false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all of the usernames and domain names, can you change them to some form of "example" please?

}
```

5. **Validate ID of domain Whitelabel**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another line between this and the one above. Currently running into one another on one line.

Copy link
Contributor

@Whatthefoxsays Whatthefoxsays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT start! Thanks for taking this on! Just a few small changes. Please let us know if you have questions.

@crweiner
Copy link
Contributor Author

Hi @Whatthefoxsays! You're awesome to review all of this for me, thank you! I'll get on making those changes in the next few days. 👍

apigirl
apigirl previously approved these changes Oct 16, 2018
@thinkingserious
Copy link
Contributor

Hello @crweiner,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@crweiner
Copy link
Contributor Author

crweiner commented Oct 17, 2018

Thank you again @Whatthefoxsays and @ksigler7 for reviewing this! Really, I greatly do appreciate your time and help!!

I just wanted to make sure of one thing that popped up, does the Username field at Line 489 here return the email address in question, or is it actually the username from Line 38 here ? I just want to make sure that I have that correctly.

Also, this is the first time I've tried to use the Review feature of Github, so if I did something wrong, please let me know so I can correct it!

Once everything is good to go, I'll be happy to remove the "[Do Not Merge]" from the PR title.

@apigirl
Copy link
Contributor

apigirl commented Oct 23, 2018

@crweiner - lgtm! you have the username correctly. Thank you SO much for all of your effort on this!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants