Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to legacy "Whitelabel" Verbiage #329

Merged
merged 10 commits into from
Jul 23, 2020

Conversation

crweiner
Copy link
Contributor

Fixes #328

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Per Issue #328, as well as a similar issue on your Python library, the term "Whitelabel" is being depreciated from SendGrid's verbiage, even though the API still references it.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Hello @crweiner,

Could you please fix the merge conflicts? Thank you!

With Best Regards,

Elmer

@crweiner
Copy link
Contributor Author

Thanks for taking a look, @thinkingserious!

I won't be able to fix the merge conflicts until after Thanksgiving, just don't have that much free time on my hands at the moment. It is on my to-do list and I will get back with you when it's done. 👍

@crweiner
Copy link
Contributor Author

Hello @thinkingserious,

The merge conflicts are now fixed and this PR has also removed references to "Whitelabel" that arose from PR #293 and Issue #237. 👍

Let me know if you need anything else! 😄

@childish-sambino childish-sambino changed the title Fix Whitelabel Verbiage docs: Remove references to legacy "Whitelabel" Verbiage Jul 15, 2020
@childish-sambino childish-sambino merged commit d474e46 into sendgrid:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Uses Outdated "Whitelabel" Verbiage
4 participants