Update CONTRIBUTING.md #527
Conversation
Updated contributing.md for sendgrid#525
thinkingserious
added
the
status: code review request
|
|
| @@ -228,4 +229,8 @@ Please run your code through: | |||
| 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/) | |||
| with a clear title and description against the `master` branch. All tests must be passing before we will review the PR. | |||
|
|
|||
| 8. ## Code Reviews<a name="code-reviews"></a> | |||
| If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some <a href="https://help.github.com/articles/about-pull-request-reviews/">great information on how to review a Pull Request.</a> | |||
There was a problem hiding this comment.
For the external link, Markdown syntax ([text](link)) might fit better with the rest of the document, although HTML technically works there. In this doc regular HTML is used for making standalone anchors like
<a name="roadmap"></abecause I believe there's no Markdown way to do it
(#roadmap) <-- doesn't workThere was a problem hiding this comment.
@gabrielkrell i see.. so should i update the file with markdown? i see that this same way is being used on line 7 so i figured it was ok to use. i appreciate the feedback tho 😄 let me know what i need to do to update this
There was a problem hiding this comment.
Yeah, I would use markdown like:
... great information on [how to review a Pull Request](https://help.github.com/articles/about-pull-request-reviews/).
This PR might not be merged though because there was one submitted just before it that covers the same thing.
|
Oops, this overlaps with #526. |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
Fixes
Checklist
Short description of what this PR does:
Updated contributing.md for #525.
Changes made
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.