Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Review to Contributing.md #525

Closed
thinkingserious opened this issue Oct 31, 2017 · 2 comments
Closed

Add Code Review to Contributing.md #525

thinkingserious opened this issue Oct 31, 2017 · 2 comments
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community

Comments

@thinkingserious
Copy link
Contributor

  • Add a "Code Reviews" section on CONTRIBUTING.md
  • Put the following under the header:

If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great information on how to review a Pull Request.

  • Link the header in the Contributing.md Table of Contents
  • Add a link to the README.md file: Review Pull Requests under "Contributing Section"
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 31, 2017
tgrecojs added a commit to tgrecojs/sendgrid-python that referenced this issue Oct 31, 2017
@tgrecojs
Update CONTRIBUTING.md
2a7b5fb 
Updated contributing.md for sendgrid#525
@tgrecojs tgrecojs mentioned this issue Oct 31, 2017
Closed
6 tasks
@shorrock
Copy link

I'd like to take this and sendgrid/smtpapi-python#59 please!

@shorrock shorrock mentioned this issue Oct 31, 2017
Closed
@delirious-lettuce delirious-lettuce mentioned this issue Oct 31, 2017
Merged
6 tasks
@jlax47
Copy link
Contributor

jlax47 commented Nov 1, 2017

I created a pull request to address this #526

@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed help wanted labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thinkingserious @mbernier @shorrock @jlax47 @childish-sambino