Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include code reviews section - Fixes #525 #526

Merged
merged 1 commit into from
Dec 11, 2017
Merged

include code reviews section - Fixes #525 #526

merged 1 commit into from
Dec 11, 2017

Conversation

jlax47
Copy link
Contributor

@jlax47 jlax47 commented Oct 31, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Updates contributing.md to include a section on code review.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

delirious-lettuce
delirious-lettuce approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@delirious-lettuce delirious-lettuce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👇

delirious-lettuce
delirious-lettuce suggested changes Oct 31, 2017
View reviewed changes
CONTRIBUTING.md Outdated

<a name="code-reviews"></a>
## Code Reviews
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great information on how to review a Pull Request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlax47 ,

I just noticed that the link from #525 is missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delirious-lettuce,

Right you are. Sorry about that. I just updated it and pushed the changes into the same commit, it's showing up for me, can you confirm?

@jlax47 jlax47 mentioned this pull request Nov 1, 2017
Closed
delirious-lettuce
delirious-lettuce approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@delirious-lettuce delirious-lettuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlax47 ,

Looks good to me!

@gabrielkrell gabrielkrell mentioned this pull request Nov 1, 2017
Closed
6 tasks
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@mbernier mbernier merged commit 5ce7aa3 into sendgrid:master Dec 11, 2017
@thinkingserious
Copy link
Contributor

Hello @jlax47,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

@jlax47

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delirious-lettuce delirious-lettuce delirious-lettuce approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlax47 @SendGridDX @thinkingserious @mbernier @delirious-lettuce @apigirl