Replace nuspec and AssemblyInfo with csproj #892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742
Replaces #743
Checklist
Short description of what this PR does:
This PR:
.nuspec
file by moving the metadata to the.csproj
fileAssemblyInfo.cs
tocsproj
.The
nuspec
is then be generated and included when packing thenupkg
.The purpose of this change is to prevent discrepancies between the
csproj
and thenuspec
file, as the dependencies are now defined a single place.Also the version number is now defined a single places, instead of spread out across three files.
Here's a copy of the generated
nuspec
, which is almost identical to the current nuspecSome notes:
PackageRequireLicenseAcceptance
is false per defaultSummary
is generated fromPackageDescription
are no longer available<owners>
will be generated fromAuthors
<id>
is specified viaPackageId
which defaults toAssemblyName
when not specifiedFor comparison here are screenshots from NuGet Package Explorer of the content.
9.11.0 from nuget.org
The
nupkg
generated from this PR