Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate csproj and nuspec #134

Closed
jnyrup opened this issue Nov 28, 2019 · 3 comments · Fixed by #135
Closed

Consolidate csproj and nuspec #134

jnyrup opened this issue Nov 28, 2019 · 3 comments · Fixed by #135

Comments

@jnyrup
Copy link
Contributor

jnyrup commented Nov 28, 2019

Incorporating the .nuspec into the .csproj has some nice benefits.
One of the major sale points is that declared dependencies are always in sync.
Currently the Newtonsoft.Json dependency and release notes are out of sync.

<dependency id="Newtonsoft.Json" version="10.0.1" />

<PackageReference Include="Newtonsoft.Json" Version="10.0.2" />

<releaseNotes>Fully RFC 7946 compliant. Deprecating GeographicPosition in favour of Position to match RFC</releaseNotes>

<PackageReleaseNotes>Assembly is now strong named</PackageReleaseNotes>

For examples on the conversion:

Let me know if you'd like any help.

@xfischer
Copy link
Member

Hi @jnyrup ! Sounds really great. Could you put that in a PR that would be nice.
@matt-lethargic are you OK with this ?

@jnyrup
Copy link
Contributor Author

jnyrup commented Nov 28, 2019

Should I target this against the master or 2 branch?
(or both?)

@matt-lethargic
Copy link
Member

matt-lethargic commented Nov 28, 2019

master I think we can basically call this feature complete and 2 hasn't really materialised! I'm happy with you creating a PR for this. I don't use nuspec files these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants