Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching dependencies between csproj and nuspec #742

Closed
bmeredith opened this issue Sep 17, 2018 · 2 comments · Fixed by #892
Closed

Mismatching dependencies between csproj and nuspec #742

bmeredith opened this issue Sep 17, 2018 · 2 comments · Fixed by #892
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: bug bug in the library

Comments

@bmeredith
Copy link

bmeredith commented Sep 17, 2018

I was excited to see #601 was merged into v9.10.0. Although it looks like the nuspec that is being used has an old set of frameworks and dependencies, which brings it back to the same point as previous in #601 + different target frameworks being used between the nuspec and csproj.

Based off of the current csproj:

  • net40 target framework has returned
  • net452 target framework is missing
  • System.Net.Http v4.3.3 is still required

Current view from Nuget:
image

@thinkingserious
Copy link
Contributor

Thanks for catching that @bmeredith!

Do you mind creating a PR against the nuspec file so I can get this right once and for all?

If not, please give me a moment and I'll make a PR and check with you for a review. Thanks!

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

Hello @bmeredith,

We are going to close this PR in favor of #892, but we wanted to say thanks for taking the time to create a PR. Please fill out this link to receive some swag. Note that we are very backlogged on swag fulfillment, so I don't have a timeline on when we can send it you.

With best regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: bug bug in the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants