Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting both apache http client and test parameters #22

Merged
merged 46 commits into from
Oct 31, 2017

Conversation

maximn
Copy link
Contributor

@maximn maximn commented Sep 12, 2017

#21

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 12, 2017
@SendGridDX
Copy link

SendGridDX commented Sep 12, 2017

CLA assistant check
All committers have signed the CLA.

@maximn
Copy link
Contributor Author

maximn commented Sep 17, 2017

@thinkingserious Hi, do you have any ETA to merge this?

@thinkingserious
Copy link
Contributor

Hello @maximn,

No ETA yet, but generally issues gain priority in our backlog with additional +1's or a PR. When we receive a PR, that provides the biggest jump in priority.

However, we are currently working an upgrade to the library and before I start coding that, I will try to clear out any outstanding PRs. I will begin work on the refactor when I get at least 3 thumbs up on it. If you have a moment, I would greatly appreciate your feedback.

With Best Regards,

Elmer

@maximn
Copy link
Contributor Author

maximn commented Sep 24, 2017

Hi, there're few thumbs up now.

This is a very simple and backward compatible change. Please have a look.

The problem is that currently we can't set up the http client that we use to send to SendGrid. This will help us a lot.

@thinkingserious
Copy link
Contributor

Thank you for the clarification!

I just need one more thumbs up on the refactor, I'm hoping that will happen this week.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 1, 2017
@maximn
Copy link
Contributor Author

maximn commented Oct 8, 2017

There're quite a few thumbs. Do you have an ETA?

@andy-trimble
Copy link
Contributor

LGTM

@amitanafy
Copy link

Hi, do you have any ETA to merge this?

@thinkingserious thinkingserious merged commit 87675ee into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @maximn,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

JyotsnaC pushed a commit to JyotsnaC/java-http-client that referenced this pull request Nov 3, 2017
Allow setting both `apache http client` and `test` parameters
@eshanholtz eshanholtz changed the title Allow setting both apache http client and test parameters feat: Allow setting both apache http client and test parameters Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.