Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Mockito to test dependency. #23

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Moved Mockito to test dependency. #23

merged 1 commit into from
Oct 12, 2017

Conversation

twistedpair
Copy link
Contributor

As referenced by this issue, Mockito should be scoped as a test dependency.

Presently we have to exclude this dependency to use the Sendgride Java Client.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 13, 2017
@SendGridDX
Copy link

SendGridDX commented Sep 13, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Awesome, thanks @twistedpair!

Could you please take a minute to sign our CLA so we can merge this?

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 1, 2017
@andy-trimble
Copy link
Contributor

LGTM

@thinkingserious thinkingserious merged commit 9205ca4 into sendgrid:master Oct 12, 2017
@thinkingserious
Copy link
Contributor

Hello @twistedpair,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Oct 12, 2017
@thinkingserious
Version Bump v4.1.1: #23 Moved Mockito to test dependency.
317a74b
@thinkingserious thinkingserious mentioned this pull request Oct 12, 2017
Closed
@twistedpair
Copy link
Contributor Author

@thinkingserious, thanks. However, I noticed that the sendgrid-java 4.1.1 artifact depends on java-http-client version 4.1.0, so this release has no effect.

The build.gradle also needs to upgraded.

@thinkingserious
Copy link
Contributor

Hi @twistedpair,

Thanks for the heads up. Would you like to make that PR? If not, I'll take care of it.

With Best Regards,

Elmer

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-trimble andy-trimble andy-trimble approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twistedpair @SendGridDX @thinkingserious @andy-trimble