Fix gradle error #45
Merged
Fix gradle error #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to pass travis build
Openjdk7 broken, see gradle/gradle#2421
thinkingserious
added
the
status: code review request
|
|
mbernier
reviewed
Oct 25, 2017
| @@ -2,7 +2,7 @@ language: java | |||
| sudo: false | |||
| jdk: | |||
| - oraclejdk8 | |||
| - openjdk7 | |||
| - openjdk8 | |||
There was a problem hiding this comment.
@thinkingserious do we need to support the jdk7? That was what was causing the issue here.
|
Related to #46 |
|
Also this: https://docs.gradle.org/current/release-notes.html#java-7-support-is-deprecated Java7 reached end of life. Kill it ded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to openjdk8 - see gradle/gradle#2421