Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle error #45

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Fix gradle error #45

merged 2 commits into from
Oct 27, 2017

Conversation

kazoni
Copy link
Contributor

@kazoni kazoni commented Oct 24, 2017

Update to openjdk8 - see gradle/gradle#2421

Trying to pass travis build
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 24, 2017

CLA assistant check
All committers have signed the CLA.

@@ -2,7 +2,7 @@ language: java
sudo: false
jdk:
- oraclejdk8
- openjdk7
- openjdk8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkingserious do we need to support the jdk7? That was what was causing the issue here.

@mbernier
Copy link
Contributor

Related to #46

@mbernier
Copy link
Contributor

Also this: https://docs.gradle.org/current/release-notes.html#java-7-support-is-deprecated

Java7 reached end of life.

Kill it ded!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 27, 2017
@mbernier mbernier merged commit 8a42b32 into sendgrid:master Oct 27, 2017
@thinkingserious
Copy link
Contributor

Hello @kazoni,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants