chore: fix version staging merge v2.6.8 #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction] (#1141) Co-authored-by: transphorm <[email protected]>
release: v2.6.8 (#1142)
chore: fix ios staging deploy (#1145)
debug auto deploy v2.6.8
chore: bump iOS build for 2.6.8
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughRemoves the legacy Android passport/NFC reader module and associated resources; updates Android app build and manifest; adds a FeedbackProvider in App.tsx; broad CI/CD workflow overhauls (new caches, concurrency, triggers, deployment paths, demo/workspace pipelines); adds composite GitHub Actions; updates repo configs (.nvmrc, yarn, ignore rules, security scanners); adjusts docs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant Cache as cache-built-deps
participant Repo as Repo (monorepo)
participant Mobile as Mobile build jobs
participant Private as android-passport-nfc-reader
Dev->>GH: Open PR (dev/staging/main)
GH->>Repo: Checkout
GH->>GH: Concurrency group start
GH->>Cache: Restore built deps (common, mobile-sdk-alpha)
alt cache hit
Cache-->>GH: cache-hit=true
else cache miss
GH->>Repo: Build dependencies (workspaces)
GH->>Cache: Save built deps
end
par iOS build
GH->>Mobile: Setup Node/Yarn/Ruby and cache
GH->>Mobile: Validate workspace/schemes
Mobile-->>GH: Build app (Debug simulator)
and Android build
GH->>Mobile: Setup Node/Yarn/JDK/NDK and cache
GH->>Private: Clone internal module (if PAT present)
Mobile-->>GH: Build APK (Debug)
end
GH-->>Dev: Status (artifacts, checks)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Suggested reviewersPoem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (50)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 20511340 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_130689_4096/mock_csca.key | View secret |
| 20511341 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha1_rsa_64321_4096/mock_csca.key | View secret |
| 20511342 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_107903_4096/mock_dsc.key | View secret |
| 20511343 | Triggered | Generic Private Key | ec732da | common/src/constants/mockCertificates.ts | View secret |
| 20511344 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_130689_4096/mock_dsc.key | View secret |
| 21022104 | Triggered | Generic Private Key | 2df4dc4 | common/src/mock_certificates/aadhaar/mockAadhaarCert.ts | View secret |
| 20511345 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_56611_4096/mock_dsc.key | View secret |
| 20511346 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_107903_4096/mock_csca.key | View secret |
| 20511347 | Triggered | Generic Private Key | ec732da | common/src/constants/mockCertificates.ts | View secret |
| 20511348 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_122125_4096/mock_csca.key | View secret |
| 20511349 | Triggered | Generic Private Key | ec732da | common/src/mock_certificates/sha256_rsa_56611_4096/mock_csca.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Chores
Refactor