release: v2.6.8 (#1142) #1143
release: v2.6.8 (#1142) #1143
Conversation
* update readme * fix ios deploy pipeline * kick off during staging merge
WalkthroughUpdates CI/CD workflows to add staging triggers, standardize gem caching around Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev
participant GH as GitHub Actions
participant Cache as Cache Service
participant iOS as iOS Build Steps
participant Android as Android Build Steps
participant Internal as Internal Repo (PAT)
Dev->>GH: Push to staging or main
alt push to staging
GH->>GH: Trigger mobile-deploy-auto.yml (staging)
GH->>iOS: Run iOS build steps (uses SELFXYZ_INTERNAL_REPO_PAT)
iOS->>Cache: Restore gems via Gemfile.lock + cache-version
GH->>Android: Run Android install deps (uses SELFXYZ_INTERNAL_REPO_PAT)
Android->>Cache: Restore gems via Gemfile.lock + cache-version
GH->>GH: Deploy to internal testing track
else push to main
GH->>GH: Trigger mobile-deploy-auto.yml (main)
GH->>iOS: Build + deps (PAT + cache)
GH->>Android: Build + deps (PAT + cache)
GH->>GH: Deploy to production track
end
Note over Cache: Single-source cache key derived from Gemfile.lock + cache-version
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
23-23: Consider adjusting heading hierarchy for better document structure.The heading jumps from h2 to h4, which can impact accessibility and document navigation. Consider changing
#### Is my document supported?to### Is my document supported?(using h3 instead of h4).As per static analysis tools (markdownlint).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/mobile-deploy-auto.yml(2 hunks).github/workflows/mobile-deploy.yml(3 hunks)README.md(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/**/*.{yml,yaml}
📄 CodeRabbit inference engine (AGENTS.md)
.github/workflows/**/*.{yml,yaml}: In GitHub Actions workflows, use shared composite caching actions from .github/actions (cache-yarn, cache-bundler, cache-gradle, cache-pods)
Do not call actions/cache directly; rely on the shared composite caching actions
When using cache actions, optionally pass cache-version (often with GH_CACHE_VERSION and tool version) for stable keys
Files:
.github/workflows/mobile-deploy-auto.yml.github/workflows/mobile-deploy.yml
🪛 markdownlint-cli2 (0.18.1)
README.md
23-23: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
🔇 Additional comments (4)
.github/workflows/mobile-deploy-auto.yml (1)
6-6: LGTM! Branch trigger aligned with deployment strategy.The workflow now correctly triggers on staging merges and maps staging to internal testing track. This aligns with the PR objective to fix the iOS deploy workflow.
Also applies to: 49-52
.github/workflows/mobile-deploy.yml (3)
180-181: LGTM! Caching refactored to use lock-file approach.The switch from key/restore-keys to lock-file-based caching with
app/Gemfile.locksimplifies cache configuration and aligns with the coding guidelines for using shared composite actions.As per coding guidelines.
729-730: LGTM! Android gems caching consistent with iOS approach.The caching configuration matches the iOS implementation, providing consistency across both platforms.
As per coding guidelines.
232-232: Ensure SELFXYZ_INTERNAL_REPO_PAT has minimal required scopes
This token is used in your GitHub Actions workflow, iOS Podfile, Android CI build script, and setup-private-modules script to clone private repos—verify it’s scoped to only what’s needed (e.g. read-onlycontents: readand, if applicable,packages: read) with no extra permissions.
transphorm
changed the title
* small tweaks to bump build * also run mobile e2e and mobile sdk changes * run mobile demo on sdk changes
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/mobile-sdk-alpha/src/client.ts (1)
121-126: Document synchronous, fire-and-forget behavior of trackEvent
trackEvent now matches the AnalyticsAdapter signature by returning void and never throws; no callers await it. Add a brief JSDoc above this method to explain that it’s intentionally fire-and-forget and any adapter errors aren’t propagated.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/mobile-e2e.yml(1 hunks).github/workflows/mobile-sdk-demo-ci.yml(1 hunks)packages/mobile-sdk-alpha/src/client.ts(1 hunks)packages/mobile-sdk-alpha/src/proving/provingMachine.ts(0 hunks)packages/mobile-sdk-demo/android/build.gradle(1 hunks)
💤 Files with no reviewable changes (1)
- packages/mobile-sdk-alpha/src/proving/provingMachine.ts
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/mobile-e2e.yml
🧰 Additional context used
📓 Path-based instructions (4)
packages/mobile-sdk-alpha/**/*.{ts,tsx}
📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)
packages/mobile-sdk-alpha/**/*.{ts,tsx}: Use strict TypeScript type checking across the codebase
Follow ESLint TypeScript-specific rules
Avoid introducing circular dependencies
Files:
packages/mobile-sdk-alpha/src/client.ts
**/*.{js,ts,tsx,jsx,sol,nr}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{js,ts,tsx,jsx,sol,nr}: NEVER log sensitive data including PII (names, DOB, passport numbers, addresses), credentials, tokens, API keys, private keys, or session identifiers.
ALWAYS redact/mask sensitive fields in logs using consistent patterns (e.g.,***-***-1234for passport numbers,J*** D***for names).
Files:
packages/mobile-sdk-alpha/src/client.ts
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/src/client.ts
.github/workflows/**/*.{yml,yaml}
📄 CodeRabbit inference engine (AGENTS.md)
.github/workflows/**/*.{yml,yaml}: In GitHub Actions workflows, use shared composite caching actions from .github/actions (cache-yarn, cache-bundler, cache-gradle, cache-pods)
Do not call actions/cache directly; rely on the shared composite caching actions
When using cache actions, optionally pass cache-version (often with GH_CACHE_VERSION and tool version) for stable keys
Files:
.github/workflows/mobile-sdk-demo-ci.yml
🧬 Code graph analysis (1)
packages/mobile-sdk-alpha/src/client.ts (2)
packages/mobile-sdk-alpha/src/index.ts (1)
TrackEventParams(27-27)packages/mobile-sdk-alpha/src/types/public.ts (1)
TrackEventParams(60-65)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: android-build-test
- GitHub Check: analyze-ios
- GitHub Check: analyze-android
- GitHub Check: e2e-ios
- GitHub Check: build-deps
🔇 Additional comments (1)
packages/mobile-sdk-demo/android/build.gradle (1)
7-7: Approve NDK revision bump to 27.0.12077973 – confirmed this release exists in the official NDK Revision History and no security advisories were found.
update readme
fix ios deploy pipeline
kick off during staging merge
Summary by CodeRabbit
Documentation
Chores
Breaking Changes