Skip to content

Conversation

@transphorm
Copy link
Member

@transphorm transphorm commented Sep 30, 2025

Summary by CodeRabbit

  • Chores
    • Enabled test mode for mobile deployment runs, allowing non-production executions of iOS and Android pipelines.
    • Improved reliability of mobile builds by ensuring required internal dependencies are accessible during build and upload steps.
    • Updated workflow permissions to support secure authentication for deployment tasks.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates GitHub Actions workflows: adds id-token permission and propagates a test_mode input in mobile-deploy-auto, and relocates/extends SELFXYZ_INTERNAL_REPO_PAT environment usage across steps in mobile-deploy to ensure internal repo access during iOS/Android build and deploy steps.

Changes

Cohort / File(s) Summary of Changes
Mobile deploy auto workflow
.github/workflows/mobile-deploy-auto.yml
Added permissions.id-token; propagated test_mode: true to deploy-ios and deploy-android step inputs; no control-flow changes.
Mobile deploy workflow
.github/workflows/mobile-deploy.yml
Removed a top-level env block for SELFXYZ_INTERNAL_REPO_PAT; added SELFXYZ_INTERNAL_REPO_PAT to specific steps: Build Dependencies (iOS), Build and upload to App Store Connect/TestFlight, and Build AAB with Fastlane; ensured PAT exposure in non-fork scenarios.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • remicolin

Poem

Pipelines hum in midnight’s glow,
Tokens minted, PATs in tow.
Test mode flags the careful run,
iOS, Android—builds are spun.
Secrets placed where steps can see—
Deploy on rails, securely free. 🚀

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin/fix-ios-deploy

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ebb916 and d395e3f.

📒 Files selected for processing (2)
  • .github/workflows/mobile-deploy-auto.yml (3 hunks)
  • .github/workflows/mobile-deploy.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm merged commit e66607b into dev Sep 30, 2025
10 of 11 checks passed
@transphorm transphorm deleted the justin/fix-ios-deploy branch September 30, 2025 03:28
transphorm added a commit that referenced this pull request Sep 30, 2025
chore: fix ios staging deploy (#1145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants