Skip to content

Conversation

@transphorm
Copy link
Member

@transphorm transphorm commented Sep 30, 2025

Summary by CodeRabbit

  • Chores
    • No user-facing changes; behind-the-scenes improvements to the mobile release pipeline.
    • Refined deployment triggers and conditions; one auto-deploy path temporarily paused.
    • Streamlined versioning, release tagging, and changelog generation post-deployment.
    • Added caching and validation steps to increase build reliability for iOS and Android.
    • Incremented iOS and Android build numbers and updated deployment timestamps.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Disables the auto-deploy workflow by forcing its condition to false. Expands mobile-deploy workflow triggers and refactors conditional logic for iOS/Android build and deploy paths, adjusting versioning/tagging branches and adding validations/caching. Increments app/version.json build numbers and timestamps.

Changes

Cohort / File(s) Summary
Disable auto-deploy workflow
.github/workflows/mobile-deploy-auto.yml
Replaces run condition with if: false (original condition retained as comment); all jobs effectively skipped.
Revise mobile deploy pipeline
.github/workflows/mobile-deploy.yml
Adds pull_request trigger (staging), refines job conditions for PR merges and manual runs, consolidates version bump into update-version job, adjusts base branches to dev for versioning/tagging, broadens upload conditions, adds caching/secret/profile validations, and augments logging/metadata.
Version metadata bump
app/version.json
Increments iOS and Android build numbers and updates lastDeployed timestamps.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions
  participant Jobs as build-android / build-ios
  participant Ver as update-version
  participant Store as Stores (Play/App Store)
  participant Repo as Repo (tags/changelog)

  Dev->>GH: Merge PR -> staging (pull_request closed + merged)
  GH->>Jobs: Conditional start (platform + PR-merged checks)
  Jobs->>Jobs: Cache/setup + validations (secrets, lockfiles, profiles)
  alt Not test_mode
    Jobs->>Store: Upload build (Android/iOS)
  else test_mode
    Jobs-->>Jobs: Skip upload
  end
  GH->>Ver: update-version (base branch: dev)
  Ver->>Repo: Open/Update version files PR
  opt Production tagging path
    GH->>Repo: Create release tag + changelog (conditional)
  end
Loading
sequenceDiagram
  autonumber
  actor Operator as Operator
  participant GH as GitHub Actions (workflow_dispatch)
  participant Jobs as build-android / build-ios
  participant Ver as update-version
  participant Repo as Repo

  Operator->>GH: Manual dispatch with inputs (platform, track, test_mode)
  GH->>Jobs: Start platform job(s) per inputs
  Jobs->>Jobs: Cache/validate, build
  alt Not test_mode
    Jobs->>Store: Upload build
  else test_mode
    Jobs-->>Jobs: Skip upload
  end
  GH->>Ver: update-version (dev)
  Ver->>Repo: Version PR and optional tagging (conditional)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • remicolin
  • aaronmgdr

Poem

Switches flipped, the auto train stands still,
While staging’s bell rings builds at will.
Numbers climb in version’s song,
Caches primed, the lanes move strong.
Tags may bloom when gates allow—
Ship it safe, and ship it now. 🚀

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin/chore-tweak-mobile-pipelines-to-fix-versioning

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16abf66 and 3bfbed9.

📒 Files selected for processing (3)
  • .github/workflows/mobile-deploy-auto.yml (1 hunks)
  • .github/workflows/mobile-deploy.yml (8 hunks)
  • app/version.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants