Skip to content

Conversation

@transphorm
Copy link
Member

@transphorm transphorm commented Oct 1, 2025

Summary by CodeRabbit

  • Chores

    • Bumped Android build number to 106 for the next mobile release.
    • Streamlined the Google Play upload step in the mobile deployment pipeline by simplifying the execution flow and removing automatic retries, using a single-step upload with a defined timeout.
  • Notes

    • No user-facing changes in this release.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced the Google Play upload step in the CI workflow to run inline without retry logic and set a 10-minute timeout. Updated Android build number in app/version.json from 105 to 106.

Changes

Cohort / File(s) Summary
CI workflow: Play Store upload step
.github/workflows/mobile-deploy.yml
Removed nick-fields/retry@v3 wrapper; now executes a single run step with timeout-minutes: 10 to call upload_to_play_store.py after selecting track. Eliminates explicit retries.
Version bump
app/version.json
Incremented android.build from 105 to 106.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as GitHub Actions
  participant Script as upload_to_play_store.py
  participant Play as Google Play API

  Note over Dev: Mobile deploy workflow (modified)
  Dev->>Dev: Determine app path and track
  Dev->>Script: Invoke with AAB, package, track (single attempt)
  Script->>Play: Upload AAB
  alt Success
    Play-->>Script: 200 OK
    Script-->>Dev: Exit 0
  else Error
    Play-->>Script: Error
    Script-->>Dev: Non-zero exit (no retry)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • remicolin

Poem

A build steps out, one notch higher we go,
The bots no longer loop—one shot, then throw.
Ten minutes to fly, or gracefully fail,
Version ticks on like a steady sail.
Ship the AAB—clean, concise, and quick.
CI hums softly: click, zip, stick.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin/release-v268-post-env-fixes

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e3b4e8 and 49f28a4.

📒 Files selected for processing (2)
  • .github/workflows/mobile-deploy.yml (1 hunks)
  • app/version.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm changed the title undo retry and bump version chore: minor fixes after android build version 107 release Oct 1, 2025
@transphorm transphorm merged commit 871890a into dev Oct 1, 2025
16 of 17 checks passed
@transphorm transphorm deleted the justin/release-v268-post-env-fixes branch October 1, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants